Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search in the top menu is easy to confuse with a button #563

Closed
yurishkuro opened this issue Apr 23, 2020 · 7 comments · Fixed by #676
Closed

Search in the top menu is easy to confuse with a button #563

yurishkuro opened this issue Apr 23, 2020 · 7 comments · Fixed by #676

Comments

@yurishkuro
Copy link
Member

yurishkuro commented Apr 23, 2020

image

The Search comes right after the textbox for trace ID and looks like a button, whereas it's actually the currently selected menu item, so clicking on it does nothing. Instead, to search by trace ID one needs to hit Enter, which is not obvious. Some users are confused by that.

A better placement for this text box would be on the right, as shown in this duplicate ticket #670

image

@everett980
Copy link
Collaborator

Disabling the navigation for the current page would prevent users from essentially refreshing by accident.
Adding a tooltip with the destination url would make it more obvious that it is a link.
And adding an interactive magnifying glass to submit the search would be better than exclusively relying on the user to hit enter.

@yurishkuro
Copy link
Member Author

Magnifying glass sgtm, followed by a bit more horizontal space or a vertical line to separate the menu

@achesin
Copy link
Contributor

achesin commented Apr 24, 2020

I had this same issue where people have mentioned to me their confusion. We thought of potentially moving the search bar to the right hand side of the TopNav, away from the Search tab to decrease confusion.

@yoave23
Copy link
Contributor

yoave23 commented Jan 6, 2021

@yurishkuro I'll be happy to take it if no one is on it

@yurishkuro
Copy link
Member Author

@yoave23 it's yours! Thanks.

@yoave23
Copy link
Contributor

yoave23 commented Jan 11, 2021

@yurishkuro how does this look?
image

@yurishkuro
Copy link
Member Author

great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants