Refactor trace detail #53

tiffon · 2017-08-11T05:48:20Z

TODO

Maintenance of tests
Cleanup unused vars, imports
Refine utils
Many styles will be moved to CSS

Deferred Tasks

(Deferred) ~~Finish shifting to transformed trace, exclusively, instead of raw trace~~
(Deferred) ~~Cleanup ordering of vars, imports~~
(Deferred) ~~Refine trace detail components~~
(Deferred) ~~Refine trace selectors~~
~~Will likely remove model/trace-viewer.js~~

SpanGraph

Fix [trace view] Span position in graph doesn't match its position in the detail #49 - Span position in graph doesn't not match its position in the detail
Ticks in span graph made to match trace detail (in number and formatting)
Span graph refactored to trim down files and DOM elements
Styling adjustments

TracePageHeader

trace prop removed
Added props for various title values instead of deriving them from trace

Trace Detail

Several components split out into separate files
transformTrace to use already created span tree to determine span depth
Fix Rename "Span Name" column #59 - "Span Name" to "Service & Operation"

Span Bar / Detail

Fix uber/jaeger#326: extraneous scrollbars in trace views
Fix Merged RPC spans not correctly shown, multi value tags not shown #55: Some tags were not being rendered due to clashing keys (observed in a log message)
Tall content scrolls via entire table instead of single table cell
Horizontal scrolling for wide content (e.g. long log values) (Fix Tag Value Span Does Not Scroll Horizontally #58)
Full width of the header is clickable for tags, process, and logs headers (instead of header text, only)
Service and endpoint are shown on mouseover anywhere in span bar row
Label on span bars no longer off-screen
Clip or hide span bars when zoomed in (instead of flush left)
Add shadow to left / right boundary when span bar view is clipped
Darkened span name column to differentiate from span bar section
Span detail left column color coded by service
Clicking span detail left column collapses detail
Clicking anywhere left of parent span name toggles children visibility
Prevent collision of logs in log entries table

SearchTracePage

Scatterplot dots are sized based on number of spans
Scatterplot dots mouseover shows trace name

Misc

Several TraceTimelineViewer / utils removed
TreeNode .walk() method can now be used to calculate the depth, avoiding use of less efficient .getPath()
Removed several console.error warnings caused by React key issues
yarn upgrade --latest
Removed react-sticky
Fix No support for Jaeger behind a reverse proxy #42 - Support URL prefix via homepage in package.json

TODO - Test are currently in a bad state - Finish shifting to transformed trace, exclusively, instead of raw trace - Misc cleanup (unused / ordering of vars, imports, etc) is outstanding while changes are WIP - Continued refinement of trace-detail components, selectors and utils - Many styles will be moved to CSS - Will likely remove `model/trace-viewer.js` SpanGraph - Fix #49 - Span position in graph doesn not match its position in the detail - Ticks in span graph made to match trace detail (in number and formatting) - Span graph refactored to trim down files and DOM elements TracePageHeader - `trace` prop removed - Added props for various title values instead of deriving them from `trace` Trace Detail - Several components split out into separate files - `transformTrace` to use alread span tree to determine span depth Span Detail - Fix uber/jaeger #326: extraneous scrollbars in trace views - Fix: Some tags were not being rendered due to clashing keys (observed in a log message) - Tall content scrolls via entire table instead of single table cell - Horizontal scrolling for wide content (e.g. long log values) - Full width of the header is clickable for tags, process, and logs headers (instead of header text, only) - Service and endpoint are shown on mouseover anywhere in span bar row Misc - Several TraceTimelineViewer / utils removed - `TreeNode` `.walk()` method can now be used to calculate the depth, avoiding use of less efficient `.getPath()` - Removed several `console.error` warnings caused by React key issues

TODO - Test are currently in a bad state - Finish shifting to transformed trace, exclusively, instead of raw trace - Misc cleanup (unused / ordering of vars, imports, etc) is outstanding while changes are WIP - Continued refinement of trace-detail components, selectors and utils - Many styles will be moved to CSS - Will likely remove `model/trace-viewer.js` Span Bar / Detail - Label on span bars no longer off-screen - Clip or hide span bars when zoomed in (insted of flush left) - Add shadow to left / right boundary when span bar view is clipped - Darkened span name column to differentiate from span bar section - Span detail left column color coded by service - Clicking span detail left column collapses detail - Clicking anywhere left of parent span name toggles children visibility

coveralls · 2017-08-20T00:36:31Z

Coverage increased (+0.09%) to 55.606% when pulling b8945ab on refactor-trace-detail-selectors into 0753092 on master.

Sub-page scrolling used for trace detail (TODO: revert this). This lays the ground work for using react-virtualized, but unfortunately has major perf issues, hence the TODO: revert. yarn upgrade --latest. Notable changes: - Removed react-sticky - react-router v4 - react-vis CSS needed to be included via a sym-link Misc tweaks: - Styling adjusted on trace mini-map - Scatterplot dots are sized based on number of spans - Scatterplot dots mouseover shows trace name

coveralls · 2017-08-20T09:58:00Z

Coverage decreased (-0.7%) to 54.826% when pulling c041353 on refactor-trace-detail-selectors into 0753092 on master.

coveralls · 2017-08-20T10:03:59Z

Coverage decreased (-0.7%) to 54.826% when pulling 9f54454 on refactor-trace-detail-selectors into 0753092 on master.

coveralls · 2017-08-20T11:07:40Z

Coverage decreased (-0.7%) to 54.863% when pulling c657cf1 on refactor-trace-detail-selectors into 0753092 on master.

yurishkuro · 2017-08-20T17:41:25Z

@tiffon why are we not breaking this up into multiple PRs?

tiffon · 2017-08-20T21:46:24Z

@yurishkuro This PR is a collection of broad-scoped refactorings with some specific, more pointed, issues also taken care of.

My thinking with this PR is to knock out the refactoring changes in one shot and take a more piece-meal approach with ticket oriented work that is coming up.

coveralls · 2017-08-20T22:34:09Z

Coverage increased (+0.4%) to 55.879% when pulling 2226744 on refactor-trace-detail-selectors into 0753092 on master.

yurishkuro · 2017-08-21T00:53:34Z

my concern is that it's going to be very hard to have quality code review given the amount of changes, many of which looks like they can be easily done in isolation. I realize that sometimes refactoring has to touch a lot of code, but it only makes it even more important to keep the blast radius as small as possible. The TODO list at the top of this issue looks like a many-weeks project plan, we don't ned to bundle everything in one diff.

tiffon · 2017-08-21T02:50:35Z

@yurishkuro I'll address the TODOs as separate PRs.

I see what you mean about the amount of changes hindering review. Definitely it is a very large change set. Many of the changes are interdependent, but a number of them are quite isolated.

I'll wrap this up and aim for more isolation in future PRs.

coveralls · 2017-08-21T02:56:18Z

Coverage increased (+0.3%) to 55.817% when pulling bef7f5b on refactor-trace-detail-selectors into 0753092 on master.

tiffon

Consider adding flowtype for xformed trace and prop types
Consider adding some maybe git hash or whatever to something to expose version of the code in a given build
In mid-term switch to semver releases (gioing into docker builds, anyway, essentially as a release)

tiffon · 2017-08-21T19:40:07Z

src/components/SearchTracePage/TraceResultsScatterPlot.js

-      </XYPlot>
-    </div>
-  );
+class TraceResultsScatterPlot extends Component {


recompose with state

tiffon · 2017-08-21T19:44:45Z

src/components/TracePage/TracePageHeader.test.js

+    traceID: 'some-trace-id',
+    name: 'some-trace-name',
+
+    // maxDepth: PropTypes.number, // eslint-disable-line react/no-unused-prop-types


tiffon · 2017-08-21T19:55:53Z

src/components/TracePage/TracePageHeader.js


 export const HEADER_ITEMS = [
  {
    key: 'timestamp',
    title: 'Trace Start',
-    renderer: trace => formatDatetime(getTraceTimestamp(trace)),
+    renderer: props => formatDatetime(props.timestampMs * 1000),


back to nano seconds

tiffon · 2017-08-21T20:03:15Z

src/components/TracePage/TraceTimelineViewer/SpanBar.js

+  onMouseOut: null,
+};
+
+const SpanBar = compose(


export default compose...

instead of *Impl

tiffon · 2017-08-21T20:05:13Z

src/components/TracePage/TraceTimelineViewer/SpanDetail.js

 const CollapsePanelStatefull = collapseEnhancer(CollapsePanel);

 function ExpandableDataTable(props) {
  const { data, label, open, onToggleOpen } = props;
  return (
-    <div className="my1 overflow-hidden" style={{ textOverflow: 'ellipsis' }}>
+    <div className="my1" style={{ textOverflow: 'ellipsis' }}>


stlye to CSS

Will handle as a separate PR.

https://github.com/uber/jaeger-ui/pull/64

tiffon · 2017-08-21T20:21:13Z

src/selectors/trace.js

-    if (parentId && spanMap.has(parentId)) {
-      // make sure that the parent gets inserted before we continue by recursing
-      insertSpanIntoTree(tree, spanMap.get(parentId), spanMap);
+export function getTraceSpanIdsAsTree(trace) {


comment this

Add back the styling that adds an ellipsis to truncated span name text.

coveralls · 2017-08-21T21:13:42Z

Coverage increased (+0.3%) to 55.817% when pulling 3797f5b on refactor-trace-detail-selectors into 0753092 on master.

https://github.com/uber/jaeger-ui/pull/53#discussion_r134313013

https://github.com/uber/jaeger-ui/pull/53#discussion_r134314020

https://github.com/uber/jaeger-ui/pull/53#discussion_r134316418

https://github.com/uber/jaeger-ui/pull/53#discussion_r134318188

coveralls · 2017-08-22T08:03:03Z

Coverage increased (+0.5%) to 56.045% when pulling d16097b on refactor-trace-detail-selectors into 0753092 on master.

https://github.com/uber/jaeger-ui/pull/53#discussion_r134321990

coveralls · 2017-08-22T16:30:45Z

Coverage increased (+0.5%) to 55.983% when pulling bdd6d7e on refactor-trace-detail-selectors into 0753092 on master.

saminzadeh

LGTM. Reviewed offline with @tiffon

* Update prettier and wrap at 110 instead of 80 * WIP commit for refactoring trace detail view TODO - Test are currently in a bad state - Finish shifting to transformed trace, exclusively, instead of raw trace - Misc cleanup (unused / ordering of vars, imports, etc) is outstanding while changes are WIP - Continued refinement of trace-detail components, selectors and utils - Many styles will be moved to CSS - Will likely remove `model/trace-viewer.js` SpanGraph - Fix #49 - Span position in graph doesn not match its position in the detail - Ticks in span graph made to match trace detail (in number and formatting) - Span graph refactored to trim down files and DOM elements TracePageHeader - `trace` prop removed - Added props for various title values instead of deriving them from `trace` Trace Detail - Several components split out into separate files - `transformTrace` to use alread span tree to determine span depth Span Detail - Fix uber/jaeger #326: extraneous scrollbars in trace views - Fix: Some tags were not being rendered due to clashing keys (observed in a log message) - Tall content scrolls via entire table instead of single table cell - Horizontal scrolling for wide content (e.g. long log values) - Full width of the header is clickable for tags, process, and logs headers (instead of header text, only) - Service and endpoint are shown on mouseover anywhere in span bar row Misc - Several TraceTimelineViewer / utils removed - `TreeNode` `.walk()` method can now be used to calculate the depth, avoiding use of less efficient `.getPath()` - Removed several `console.error` warnings caused by React key issues * WIP commit for refactoring trace detail view TODO - Test are currently in a bad state - Finish shifting to transformed trace, exclusively, instead of raw trace - Misc cleanup (unused / ordering of vars, imports, etc) is outstanding while changes are WIP - Continued refinement of trace-detail components, selectors and utils - Many styles will be moved to CSS - Will likely remove `model/trace-viewer.js` Span Bar / Detail - Label on span bars no longer off-screen - Clip or hide span bars when zoomed in (insted of flush left) - Add shadow to left / right boundary when span bar view is clipped - Darkened span name column to differentiate from span bar section - Span detail left column color coded by service - Clicking span detail left column collapses detail - Clicking anywhere left of parent span name toggles children visibility * WIP refactor trace detail, split out css, start fixing tests * WIP refactor trace detail, tests working again * WIP refactor trace, yarn upgrade Sub-page scrolling used for trace detail (TODO: revert this). This lays the ground work for using react-virtualized, but unfortunately has major perf issues, hence the TODO: revert. yarn upgrade --latest. Notable changes: - Removed react-sticky - react-router v4 - react-vis CSS needed to be included via a sym-link Misc tweaks: - Styling adjusted on trace mini-map - Scatterplot dots are sized based on number of spans - Scatterplot dots mouseover shows trace name * WIP refactor trace, test maintenance * remove unused import * add license to css files * Revert sub-page scrolling for trace detail * Support URL prefix via homepage in package.json * Prevent collision of logs in log entries table * Add comments to new utils * WIP Use react-virtualized in trace detail view * Fix #59 - "Span Name" to "Service & Operation" * Fix unreleased regression - ellipsis on span name Add back the styling that adds an ellipsis to truncated span name text. * Address PR comment on search results scatter plot https://github.com/uber/jaeger-ui/pull/53#discussion_r134313013 * Misc cleanup from PR comment https://github.com/uber/jaeger-ui/pull/53#discussion_r134314020 * PR comment - Remove ms and use nano seconds https://github.com/uber/jaeger-ui/pull/53#discussion_r134316418 * PR comment - Adjust export, relates to recompose https://github.com/uber/jaeger-ui/pull/53#discussion_r134318188 * Reorganize span detail components * PR comment - Comment getTraceSpanIdsAsTree() https://github.com/uber/jaeger-ui/pull/53#discussion_r134321990 * PR comment - Add "SpanID:" label https://github.com/uber/jaeger-ui/pull/64#issuecomment-324080675 * WIP react-virtualized layout progress Outstanding: - Window scroller used https://bvaughn.github.io/react-virtualized/#/components/WindowScroller - Expanding span details - Collapsing / expanding children * WIP react-virtualized layout progress Switching to use a props oriented ui state management for span details. This is necessary because the virtualized scroller removes and adds span details as it scrolls. The span detail components cannot retain their own state (e.g. tags table is expanded / collapsed, etc.) because they are not long-lived. * PR comment - Flow typing for props https://github.com/uber/jaeger-ui/pull/64#discussion_r134792924 * WIP Switching react-virtualized to custom solution * fix file-header licenses * WIP Switching react-virtualized to custom solution * Add flow to ListView, comment ListView, Positions * Positions tests, fix edge-case bug in Positions * Fix comment issue from prettier * Unit tests for ListView, remove unused propType/* * Minor changes to a comment and a test case description * Unit tests for TraceTimelineViewer/duck * remove react-virtualized from package.json * PR feedback - JSDoc, move trace transform - JSDoc tweaks - documentation.js can infer types automatically - Move trace transform - Move trace tranform out of src/components/TracePage/TraceTimelineViewer/transforms and into src/model/transform-trace-data.js - Apply trace transform to data from HTTP response so the trace data stored in the state is always the enriched form * Use top-level redux store for traceTimeline state

Top level tasks - Maintenance of tests - Cleanup unused vars, imports - Refine utils - Many styles will be moved to CSS SpanGraph - Fix #49 - Span position in graph doesn't not match its position in the detail - Ticks in span graph made to match trace detail (in number and formatting) - Span graph refactored to trim down files and DOM elements - Styling adjustments TracePageHeader - `trace` prop removed - Added props for various title values instead of deriving them from `trace` Trace Detail - Several components split out into separate files - `transformTrace` to use already created span tree to determine span depth - Fix jaegertracing#59 - "Span Name" to "Service & Operation" Span Bar / Detail - Fix uber/jaeger#326: extraneous scrollbars in trace views - Fix #55: Some tags were not being rendered due to clashing keys (observed in a log message) - Tall content scrolls via entire table instead of single table cell - Horizontal scrolling for wide content (e.g. long log values) (Fix jaegertracing#58) - Full width of the header is clickable for tags, process, and logs headers (instead of header text, only) - Service and endpoint are shown on mouseover anywhere in span bar row - Label on span bars no longer off-screen - Clip or hide span bars when zoomed in (instead of flush left) - Add shadow to left / right boundary when span bar view is clipped - Darkened span name column to differentiate from span bar section - Span detail left column color coded by service - Clicking span detail left column collapses detail - Clicking anywhere left of parent span name toggles children visibility - Prevent collision of logs in log entries table SearchTracePage - Scatterplot dots are sized based on number of spans - Scatterplot dots mouseover shows trace name Misc - Several TraceTimelineViewer / utils removed - `TreeNode` `.walk()` method can now be used to calculate the depth, avoiding use of less efficient `.getPath()` - Removed several `console.error` warnings caused by React key issues - `yarn upgrade --latest` - Removed `react-sticky` - Fix #42 - Support URL prefix via homepage in package.json Commits * Update prettier and wrap at 110 instead of 80 * WIP commit for refactoring trace detail view * WIP refactor trace detail, split out css, start fixing tests * WIP refactor trace detail, tests working again * WIP refactor trace, yarn upgrade Sub-page scrolling used for trace detail (TODO: revert this). This lays the ground work for using react-virtualized, but unfortunately has major perf issues, hence the TODO: revert. yarn upgrade --latest. Notable changes: - Removed react-sticky - react-router v4 - react-vis CSS needed to be included via a sym-link Misc tweaks: - Styling adjusted on trace mini-map - Scatterplot dots are sized based on number of spans - Scatterplot dots mouseover shows trace name * WIP refactor trace, test maintenance * remove unused import * add license to css files * Revert sub-page scrolling for trace detail * Support URL prefix via homepage in package.json * Prevent collision of logs in log entries table * Add comments to new utils * Fix jaegertracing#59 - "Span Name" to "Service & Operation" * Fix unreleased regression - ellipsis on span name Add back the styling that adds an ellipsis to truncated span name text. * Address PR comment on search results scatter plot https://github.com/uber/jaeger-ui/pull/53#discussion_r134313013 * Misc cleanup from PR comment https://github.com/uber/jaeger-ui/pull/53#discussion_r134314020 * PR comment - Remove ms and use nano seconds https://github.com/uber/jaeger-ui/pull/53#discussion_r134316418 * PR comment - Adjust export, relates to recompose https://github.com/uber/jaeger-ui/pull/53#discussion_r134318188 * PR comment - Comment getTraceSpanIdsAsTree() https://github.com/uber/jaeger-ui/pull/53#discussion_r134321990 Signed-off-by: vvvprabhakar <[email protected]>

* Update prettier and wrap at 110 instead of 80 * WIP commit for refactoring trace detail view TODO - Test are currently in a bad state - Finish shifting to transformed trace, exclusively, instead of raw trace - Misc cleanup (unused / ordering of vars, imports, etc) is outstanding while changes are WIP - Continued refinement of trace-detail components, selectors and utils - Many styles will be moved to CSS - Will likely remove `model/trace-viewer.js` SpanGraph - Fix #49 - Span position in graph doesn not match its position in the detail - Ticks in span graph made to match trace detail (in number and formatting) - Span graph refactored to trim down files and DOM elements TracePageHeader - `trace` prop removed - Added props for various title values instead of deriving them from `trace` Trace Detail - Several components split out into separate files - `transformTrace` to use alread span tree to determine span depth Span Detail - Fix uber/jaeger jaegertracing#326: extraneous scrollbars in trace views - Fix: Some tags were not being rendered due to clashing keys (observed in a log message) - Tall content scrolls via entire table instead of single table cell - Horizontal scrolling for wide content (e.g. long log values) - Full width of the header is clickable for tags, process, and logs headers (instead of header text, only) - Service and endpoint are shown on mouseover anywhere in span bar row Misc - Several TraceTimelineViewer / utils removed - `TreeNode` `.walk()` method can now be used to calculate the depth, avoiding use of less efficient `.getPath()` - Removed several `console.error` warnings caused by React key issues * WIP commit for refactoring trace detail view TODO - Test are currently in a bad state - Finish shifting to transformed trace, exclusively, instead of raw trace - Misc cleanup (unused / ordering of vars, imports, etc) is outstanding while changes are WIP - Continued refinement of trace-detail components, selectors and utils - Many styles will be moved to CSS - Will likely remove `model/trace-viewer.js` Span Bar / Detail - Label on span bars no longer off-screen - Clip or hide span bars when zoomed in (insted of flush left) - Add shadow to left / right boundary when span bar view is clipped - Darkened span name column to differentiate from span bar section - Span detail left column color coded by service - Clicking span detail left column collapses detail - Clicking anywhere left of parent span name toggles children visibility * WIP refactor trace detail, split out css, start fixing tests * WIP refactor trace detail, tests working again * WIP refactor trace, yarn upgrade Sub-page scrolling used for trace detail (TODO: revert this). This lays the ground work for using react-virtualized, but unfortunately has major perf issues, hence the TODO: revert. yarn upgrade --latest. Notable changes: - Removed react-sticky - react-router v4 - react-vis CSS needed to be included via a sym-link Misc tweaks: - Styling adjusted on trace mini-map - Scatterplot dots are sized based on number of spans - Scatterplot dots mouseover shows trace name * WIP refactor trace, test maintenance * remove unused import * add license to css files * Revert sub-page scrolling for trace detail * Support URL prefix via homepage in package.json * Prevent collision of logs in log entries table * Add comments to new utils * WIP Use react-virtualized in trace detail view * Fix jaegertracing#59 - "Span Name" to "Service & Operation" * Fix unreleased regression - ellipsis on span name Add back the styling that adds an ellipsis to truncated span name text. * Address PR comment on search results scatter plot https://github.com/uber/jaeger-ui/pull/53#discussion_r134313013 * Misc cleanup from PR comment https://github.com/uber/jaeger-ui/pull/53#discussion_r134314020 * PR comment - Remove ms and use nano seconds https://github.com/uber/jaeger-ui/pull/53#discussion_r134316418 * PR comment - Adjust export, relates to recompose https://github.com/uber/jaeger-ui/pull/53#discussion_r134318188 * Reorganize span detail components * PR comment - Comment getTraceSpanIdsAsTree() https://github.com/uber/jaeger-ui/pull/53#discussion_r134321990 * PR comment - Add "SpanID:" label https://github.com/uber/jaeger-ui/pull/64#issuecomment-324080675 * WIP react-virtualized layout progress Outstanding: - Window scroller used https://bvaughn.github.io/react-virtualized/#/components/WindowScroller - Expanding span details - Collapsing / expanding children * WIP react-virtualized layout progress Switching to use a props oriented ui state management for span details. This is necessary because the virtualized scroller removes and adds span details as it scrolls. The span detail components cannot retain their own state (e.g. tags table is expanded / collapsed, etc.) because they are not long-lived. * PR comment - Flow typing for props https://github.com/uber/jaeger-ui/pull/64#discussion_r134792924 * WIP Switching react-virtualized to custom solution * fix file-header licenses * WIP Switching react-virtualized to custom solution * Add flow to ListView, comment ListView, Positions * Positions tests, fix edge-case bug in Positions * Fix comment issue from prettier * Unit tests for ListView, remove unused propType/* * Minor changes to a comment and a test case description * Unit tests for TraceTimelineViewer/duck * remove react-virtualized from package.json * PR feedback - JSDoc, move trace transform - JSDoc tweaks - documentation.js can infer types automatically - Move trace transform - Move trace tranform out of src/components/TracePage/TraceTimelineViewer/transforms and into src/model/transform-trace-data.js - Apply trace transform to data from HTTP response so the trace data stored in the state is always the enriched form * Use top-level redux store for traceTimeline state Signed-off-by: vvvprabhakar <[email protected]>

tiffon added 2 commits August 11, 2017 01:21

Update prettier and wrap at 110 instead of 80

fe35bbd

tiffon requested review from yurishkuro and saminzadeh August 11, 2017 05:48

tiffon changed the title ~~[WIP] Refactor trace detail selectors~~ [WIP] Refactor trace detail Aug 17, 2017

tiffon added 2 commits August 17, 2017 04:50

WIP refactor trace detail, split out css, start fixing tests

93a6fb7

WIP refactor trace detail, tests working again

b8945ab

tiffon added 3 commits August 20, 2017 05:26

WIP refactor trace, test maintenance

c34bbd3

remove unused import

c041353

add license to css files

9f54454

Revert sub-page scrolling for trace detail

c657cf1

Support URL prefix via homepage in package.json

2226744

Prevent collision of logs in log entries table

f555e8b

Add comments to new utils

bef7f5b

This was referenced Aug 21, 2017

Tag Value Span Does Not Scroll Horizontally #58

Closed

Merged RPC spans not correctly shown, multi value tags not shown #55

Closed

No support for Jaeger behind a reverse proxy #42

Closed

tiffon commented Aug 21, 2017

View reviewed changes

tiffon added 2 commits August 21, 2017 17:02

Fix #59 - "Span Name" to "Service & Operation"

fa6f016

Fix unreleased regression - ellipsis on span name

3797f5b

Add back the styling that adds an ellipsis to truncated span name text.

tiffon mentioned this pull request Aug 21, 2017

Make width of left column adjustable in trace detail view #63

Closed

tiffon added 4 commits August 21, 2017 17:57

Address PR comment on search results scatter plot

0fd43f5

https://github.com/uber/jaeger-ui/pull/53#discussion_r134313013

Misc cleanup from PR comment

542c1ba

https://github.com/uber/jaeger-ui/pull/53#discussion_r134314020

PR comment - Remove ms and use nano seconds

42736e0

https://github.com/uber/jaeger-ui/pull/53#discussion_r134316418

PR comment - Adjust export, relates to recompose

d16097b

https://github.com/uber/jaeger-ui/pull/53#discussion_r134318188

tiffon mentioned this pull request Aug 22, 2017

Reorganize span detail components #64

Merged

PR comment - Comment getTraceSpanIdsAsTree()

bdd6d7e

https://github.com/uber/jaeger-ui/pull/53#discussion_r134321990

tiffon changed the title ~~[WIP] Refactor trace detail~~ Refactor trace detail Aug 22, 2017

saminzadeh approved these changes Aug 22, 2017

View reviewed changes

tiffon merged commit 69d84b9 into master Aug 23, 2017

This was referenced Aug 24, 2017

Change to use node >= 6 via .nvmrc #67

Merged

Update react-scripts to 1.0 #25

Closed

tiffon mentioned this pull request Sep 24, 2017

Left panel "Find Traces" is not scrollable #16

Closed

NicolasT mentioned this pull request Nov 1, 2017

Rendering traces with spans containing a 'FOLLOWS_FROM' reference seems broken #115

Closed

tiffon mentioned this pull request Nov 2, 2017

Handle FOLLOWS_FROM ref type #118

Merged

yurishkuro deleted the refactor-trace-detail-selectors branch January 29, 2020 15:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor trace detail #53

Refactor trace detail #53

tiffon commented Aug 11, 2017 •

edited

Loading

coveralls commented Aug 20, 2017

coveralls commented Aug 20, 2017

coveralls commented Aug 20, 2017

coveralls commented Aug 20, 2017

yurishkuro commented Aug 20, 2017

tiffon commented Aug 20, 2017

coveralls commented Aug 20, 2017

yurishkuro commented Aug 21, 2017

tiffon commented Aug 21, 2017

coveralls commented Aug 21, 2017

tiffon left a comment

tiffon Aug 21, 2017

tiffon Aug 21, 2017

tiffon Aug 21, 2017

tiffon Aug 21, 2017

tiffon Aug 21, 2017

tiffon Aug 21, 2017

tiffon Aug 21, 2017

tiffon Aug 22, 2017

tiffon Aug 21, 2017

tiffon Aug 22, 2017

tiffon Aug 22, 2017

tiffon Aug 21, 2017

tiffon Aug 22, 2017

coveralls commented Aug 21, 2017

coveralls commented Aug 22, 2017

coveralls commented Aug 22, 2017

saminzadeh left a comment

Refactor trace detail #53

Refactor trace detail #53

Conversation

tiffon commented Aug 11, 2017 • edited Loading

TODO

Deferred Tasks

SpanGraph

TracePageHeader

Trace Detail

Span Bar / Detail

SearchTracePage

Misc

coveralls commented Aug 20, 2017

coveralls commented Aug 20, 2017

coveralls commented Aug 20, 2017

coveralls commented Aug 20, 2017

yurishkuro commented Aug 20, 2017

tiffon commented Aug 20, 2017

coveralls commented Aug 20, 2017

yurishkuro commented Aug 21, 2017

tiffon commented Aug 21, 2017

coveralls commented Aug 21, 2017

tiffon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Aug 21, 2017

coveralls commented Aug 22, 2017

coveralls commented Aug 22, 2017

saminzadeh left a comment

Choose a reason for hiding this comment

tiffon commented Aug 11, 2017 •

edited

Loading