Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Left panel "Find Traces" is not scrollable #16

Closed
pavolloffay opened this issue May 11, 2017 · 10 comments
Closed

Left panel "Find Traces" is not scrollable #16

pavolloffay opened this issue May 11, 2017 · 10 comments

Comments

@pavolloffay
Copy link
Member

When I zoom in browser I am not able to see the bottom of left panel "Find Traces" neither to scroll down. I'm only able to scroll down trace instances.

jaeger-zoom-in-100per

This issue was reported here in Red Hat MSA project when Jaeger is embedded in an iframe:
msa-zoom-in-find-traces-not-scrollable

@rafabene
Copy link

It also happens to me in a Mac with a resolution of 1280 x 800.

@saminzadeh
Copy link
Member

Gathering some feedback on this, should we make each side scrollable or just have the whole page scroll without having the "Find Traces" section fixed?

@pavolloffay
Copy link
Member Author

I would vote for

"Find Traces" section fixed

@rafabene
Copy link

I think that having both sides scrollable won't help if the user is not familiar with the UI. He won't understand that he has to scroll the right side to see a button that he has know idea that it exists.

My four cents (not in order of priority):

  • Change the filter to be horizontal instead of vertical
  • Change the button to the top (It might not be the best UX)
  • Trigger the find button on the combo change selection event - This would allow people not familiar to the screen to see something happening even if not clicking/finding the button.
  • Scroll both sides :)

@yurishkuro
Copy link
Member

I don't like making the panel horizontal - it's what Zipkin does and it looks awful.

I prefer making the search params panel scrollable. To improve its usability

  • make the Search button (and add Reset button) to be fixed at the bottom (not scrollable)
  • add some visual indicator that panel can be scroller when it doesn't have enough vertical space

@objectiser
Copy link
Contributor

Another option might be to place some of the components within collapsible regions - for example the lookback, min/max durations could be collapsed in a region entitled "Time Range". This would reduce the initial height so overcome the original problem.

@yurishkuro
Copy link
Member

We're exploring possible solution in #20

@tiffon
Copy link
Member

tiffon commented Sep 24, 2017

The original issue of the search form not scrolling was resolved in #53 with the removal of react-sticky. It's now scrollable as a regular page element.

screen shot 2017-09-24 at 1 16 20 am

The other UX directions discussed in this ticket have not been implemented.

@yurishkuro Is there a consensus on where the other UX changes have landed?

@yurishkuro
Copy link
Member

It's now scrollable as a regular page element.

it's not ideal but at least makes the form usable with zoom-in. I suggest closing this; #20 will take care of it in the long term.

@tiffon
Copy link
Member

tiffon commented Sep 29, 2017

Fixed by #53.

@tiffon tiffon closed this as completed Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants