-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[experimental] Change search panel to a single horizontal textbox #20
Comments
A couple of options around implementation:
Probably the best implementation of this feature, that I've seen, is the search input in the Smart Search feature of YouTrack. |
Yes, the YouTrack implementation looks very similar to what I had in mind. As long as the generic auto-completion component is implemented, the actual query syntax can be fairly straightforward to implement as a simple state machine. |
+1 I think this is a great idea. Follow up question: Should this just be UI sugar, or is it better to have a query DSL on the backend that can interpret these queries? |
I think it should be just the UI feature. Because auto-complete is critical for such feature, it means the UI will already have a structured data model representing the query, not just a free form text, therefore there's no reason why the backend should be exposed to that. BTW, to add a bit more, I think it would be useful to display already parsed / recognized tokens similar to how GitHub does it for labels: |
As a reference point, I took a look at the search interface in Facebook's ad management UI. FB has taken a structured approach. This seems appropriate for complex search / filter functionality. As it stands, the Jaeger UI search is straight-forward, but if there are plans to make it more expressive then a similarly structured approach might be worth considering. Features like the following are simple in and of themselves, but they add up quickly if a number of them are included:
Another aspect of the structured approach is discoverability for new users. This would only matter if the search functionality is made more expressive. Some screenshots: |
Overall I like it, but one thing I don't like is that it seems the filter cannot be entered (or removed) without using the mouse. The way I imagined this working in a textbox is similar to these screenshots, except the Add |
IMO a UX along the lines of what you've described would be ideal. An example of the approach is the recipient entry in gmail, which also allows editing on `enter` in addition to deletion on `delete` or `backspace`. It should be possible to achieve it with a structured approach. It can be a bit tricky, but I've done it in the past with a filter implementation.
|
I'd be curious to hear from @yurishkuro why advanced users would prefer this interface over the current interface (or potentially an improved version of the current interface, but with the same concept of a form of multiple fields). I suspect advanced users would prefer it if they don't like hitting tab to go from one form field to the next, especially skipping over form fields they don't need; and generally it's less distracting I think if they can do everything on the same horizontal line, instead of making your eyes jump all over a form. Having provided a similar query input approach to users in the past (http://vimeo.github.io/graph-explorer) the feedback i constantly got is that new users wanted a very obvious way to be gently guided into all the searching/filtering possibilities. that said, my query input was nowhere near as helpful with autocompletions and widgets as yours is, but still the warning holds. I generally like the concept though. |
It could be an alternative way of displaying search params for advanced users. The idea is that you just type things into the textbox and some intelli-sense helper provides auto-completion. E.g.:
The text was updated successfully, but these errors were encountered: