-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explain time zone of the lookback parameter #154
Comments
Sounds good. Is Also, as a bit of an aside, I'll add a note to the "Tags" info tooltip noting only exact matches are supported. |
Can you identify the timezone from the browser so that's it's always relevant to the user? |
Yes, we can get the timezone the browser is using, but, what timezone does the query-service generally interpret the date/time as? |
query-service doesn't interpret it, because UI is passing a Unix timestamp, which is relative to an absolute point in time, midnight of Jan 1 1970 in UTC time. |
Got it. Yes, I can add a note stating the time-values being entered are in local timezone of the browser and will be converted to UTC when sent to the server. |
"local" is good, but actually showing what it is is even better. |
@yurishkuro I agree, 100%. |
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [npm-run-all2](https://redirect.github.com/bcomnes/npm-run-all2) | [`6.2.2` -> `7.0.1`](https://renovatebot.com/diffs/npm/npm-run-all2/6.2.2/7.0.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/npm-run-all2/7.0.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/npm-run-all2/7.0.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/npm-run-all2/6.2.2/7.0.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/npm-run-all2/6.2.2/7.0.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>bcomnes/npm-run-all2 (npm-run-all2)</summary> ### [`v7.0.1`](https://redirect.github.com/bcomnes/npm-run-all2/blob/HEAD/CHANGELOG.md#v701) [Compare Source](https://redirect.github.com/bcomnes/npm-run-all2/compare/v7.0.0...v7.0.1) ##### Commits - Revert engine range bump back to Node 18 [`b2e849b`](https://redirect.github.com/bcomnes/npm-run-all2/commit/b2e849bf8d31135751dd7458724344dd1bca120e) ### [`v7.0.0`](https://redirect.github.com/bcomnes/npm-run-all2/blob/HEAD/CHANGELOG.md#v700---2024-10-21) [Compare Source](https://redirect.github.com/bcomnes/npm-run-all2/compare/v6.2.6...v7.0.0) ##### Merged - Prevent a throw when looking up undefined results [`#158`](https://redirect.github.com/bcomnes/npm-run-all2/pull/158) ##### Commits - **Breaking change:** Bump node engines ^18.17.0 || >=20.5.0 [`49b95f0`](https://redirect.github.com/bcomnes/npm-run-all2/commit/49b95f0c4905504a94d1a7ce87fbb7e77ab60df5) - Merge pull request [#​156](https://redirect.github.com/bcomnes/npm-run-all2/issues/156) from bcomnes/rm-rf-rimraf [`c661ffc`](https://redirect.github.com/bcomnes/npm-run-all2/commit/c661ffc942e09a68b1a553190d3a550dc0f6a39c) - Remove rimraf [`c77e085`](https://redirect.github.com/bcomnes/npm-run-all2/commit/c77e0856c65115b32788c3e9a1e441ba69fbd430) ### [`v6.2.6`](https://redirect.github.com/bcomnes/npm-run-all2/blob/HEAD/CHANGELOG.md#v626---2024-10-21) [Compare Source](https://redirect.github.com/bcomnes/npm-run-all2/compare/ee3bf122e700102b9ab27b1d172d98856765f4a4...v6.2.6) ##### Commits - Prevent a throw when looking up undefined results [`d928f9a`](https://redirect.github.com/bcomnes/npm-run-all2/commit/d928f9ad59c00a20797c90d35b62ef0aecf0c364) ### [`v6.2.5`](https://redirect.github.com/bcomnes/npm-run-all2/compare/v6.2.4...ee3bf122e700102b9ab27b1d172d98856765f4a4) [Compare Source](https://redirect.github.com/bcomnes/npm-run-all2/compare/v6.2.4...ee3bf122e700102b9ab27b1d172d98856765f4a4) ### [`v6.2.4`](https://redirect.github.com/bcomnes/npm-run-all2/blob/HEAD/CHANGELOG.md#v624) [Compare Source](https://redirect.github.com/bcomnes/npm-run-all2/compare/v6.2.3...v6.2.4) ##### Merged - Switch to JS-based `which` command [`#154`](https://redirect.github.com/bcomnes/npm-run-all2/pull/154) ##### Fixed - Switch to JS-based `which` command [`#153`](https://redirect.github.com/bcomnes/npm-run-all2/issues/153) ### [`v6.2.3`](https://redirect.github.com/bcomnes/npm-run-all2/blob/HEAD/CHANGELOG.md#v623) [Compare Source](https://redirect.github.com/bcomnes/npm-run-all2/compare/v6.2.2...v6.2.3) ##### Commits - Merge pull request [#​151](https://redirect.github.com/bcomnes/npm-run-all2/issues/151) from bcomnes/fix-pnpm-agian [`c43fa2b`](https://redirect.github.com/bcomnes/npm-run-all2/commit/c43fa2b677442c710a29654a333b15c8de4f00ab) - Avoid passing config fields as flags for pnpm [`dc2d7da`](https://redirect.github.com/bcomnes/npm-run-all2/commit/dc2d7da61cf0898d0bc2b25747e588325e06b9a9) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/jaegertracing/jaeger-ui). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xMS41IiwidXBkYXRlZEluVmVyIjoiMzkuMTEuNSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiY2hhbmdlbG9nOmRlcGVuZGVuY2llcyJdfQ==--> Signed-off-by: Mend Renovate <[email protected]>
Moved from jaegertracing/jaeger#372
When "Custom Time Range" is specified, it would be good to show in which time zone the entered values are interpreted, either via
(?)
icon or explicitly "Start Time (TZ=New York [UTC-0500])".The text was updated successfully, but these errors were encountered: