Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jaeger-query UI suggestions #372

Closed
Dieterbe opened this issue Sep 3, 2017 · 4 comments
Closed

jaeger-query UI suggestions #372

Dieterbe opened this issue Sep 3, 2017 · 4 comments
Labels

Comments

@Dieterbe
Copy link
Contributor

Dieterbe commented Sep 3, 2017

would be nice to have a litle (?) icon for some fields with more information, in particular i'ld like to know:

  • custom time range -> what timezone is this in? same as browser, same as server? can it confirm? option to specify TZ would be nice too
  • tags: what format exactly? do some characters need escaping? which? how? can we do pattern searches or only literal strings? using what pattern syntax?
  • tags: how to specify multiple with an AND condition? i saw in the jaeger-query source code that the handler is passed multiple tag form fields, but through the ui I think you can only pass one, and whatever you put in there (space separated or common separated) is sent as 1 tag field AFAICT ? possible to do OR and/or nested expressions? does it matter if the tag is found the main span or a client span? (doesn't look like it)
@rbtcollins
Copy link
Contributor

I've just audited the code. Multiple tags given e.g. http.status_code:400|http.method:PATCH in the UI will result in an AND query in cassandra. https://github.com/jaegertracing/jaeger/blob/master/plugin/storage/cassandra/spanstore/reader.go#L295

I think it would be good to do two things:

  1. add an OR semantic, because it would be very useful.
  2. Change the ui so that | means OR, and & means AND. Because that matches other languages developers use :). Even the sample query the UI shows today is actually never going to return anything due to the current AND semantics.

@black-adder black-adder added the ui label Nov 28, 2017
@Dieterbe
Copy link
Contributor Author

@tiffon FYI ^^ (sorry maybe i should have put this in the jaeger-ui repo). i have a better understanding of the limitations now (e.g. no tag pattern search with cassandra) but the points remain that the UI could clarify a lot of these questions for new users

@tiffon
Copy link
Member

tiffon commented Nov 29, 2017

Thanks @Dieterbe... I was looking this over yesterday, it's great feedback 👍

We've added the ui label to track this more easily. I might end up creating tickets in the Jaeger UI repo or moving this ticket there...

@yurishkuro
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants