-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added basic status to CR{D} #802
Added basic status to CR{D} #802
Conversation
According to people on the #forum-operator-fw in the CoreOS slack, the |
b690e2a
to
5067478
Compare
This PR is now ready to be reviewed. There's still one thing that could be better: when creating a CR, it would be good to have the initial state as "Pending". But to do that, we have to persist the status and finish the reconciliation loop, as this change itself will trigger an update. I decided to not add the |
PR updated. |
0890535
to
29e442c
Compare
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
29e442c
to
8c5197c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds a new
JaegerPhase
type, added to theJaegerStatus
. When runningkubectl get jaegers
, this is what is shown now:When getting the output as YAML for a specific instance, here's the output:
And here's how it shows up in OLM:
Note that the
Version
field isn't being showed in OLM yet.This is related to #259, although it won't close it, as we might want to keep that open to discuss further status fields in the future.
Signed-off-by: Juraci Paixão Kröhling [email protected]