Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jaeger-operator]: update jaeger crd to include status resource #20

Merged
merged 1 commit into from
Jan 18, 2020

Conversation

alexsn
Copy link
Contributor

@alexsn alexsn commented Dec 29, 2019

CRD changes from #802 should be merged into operator helm chart as currently the following errors are seen on logs:

time="2019-12-29T09:56:25Z" level=error msg="failed to store the running status into the current CustomResource" error="the server could not find the requested resource (put jaegers.jaegertracing.io jaeger-operator-jaeger)" execution="2019-12-29 09:56:24.974520864 +0000 UTC" instance=jaeger-operator-jaeger namespace=observability
time="2019-12-29T10:12:40Z" level=error msg="failed to store the running status into the current CustomResource" error="the server could not find the requested resource (put jaegers.jaegertracing.io jaeger-operator-jaeger)" execution="2019-12-29 10:12:40.637487009 +0000 UTC" instance=jaeger-operator-jaeger namespace=observability
time="2019-12-29T10:13:05Z" level=error msg="failed to store the running status into the current CustomResource" error="the server could not find the requested resource (put jaegers.jaegertracing.io jaeger-operator-jaeger)" execution="2019-12-29 10:13:05.029591192 +0000 UTC" instance=jaeger-operator-jaeger namespace=observability

@alexsn alexsn changed the title jaeger-operator: update jaeger crd to include status resource [jaeger-operator]: update jaeger crd to include status resource Dec 29, 2019
@naseemkullah naseemkullah requested a review from cpanato December 30, 2019 02:35
@alexsn
Copy link
Contributor Author

alexsn commented Jan 9, 2020

Can someone please review this?

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the delay

@cpanato
Copy link
Member

cpanato commented Jan 9, 2020

@alexsn looks like you need to sign your commits, please see: https://help.github.com/en/github/authenticating-to-github/about-commit-signature-verification

@alexsn
Copy link
Contributor Author

alexsn commented Jan 9, 2020

Commit is signed as far as I can see: 1cf22e2

@cpanato
Copy link
Member

cpanato commented Jan 9, 2020

@alexsn the DCO is signed not the commit, please take a look in the link above

Copy link
Contributor

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@naseemkullah naseemkullah merged commit 515b15e into jaegertracing:master Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants