Add support for TLS on ingress #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 2, 2019 21:17
Signed-off-by: Cedric Kring <[email protected]>
Signed-off-by: Cedric Kring <[email protected]>
cedrickring
force-pushed
the
add-ingress-tls-support
branch
from
fc75f1c to
0c31233
Compare
Signed-off-by: Cedric Kring <[email protected]>
cedrickring
force-pushed
the
add-ingress-tls-support
branch
from
13ee692 to
efb119e
Compare
Signed-off-by: Cedric Kring <[email protected]>
cedrickring
force-pushed
the
add-ingress-tls-support
branch
from
60d0f5f to
ae2decc
Compare
jpkrohling
approved these changes
Oct 7, 2019
|
Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #85.
I didn't add the auto lookup of an existing secret like
<instance-name>-tls-secret. This would require the client to be accessible iningress/query.go.