Document secretName support for Ingress TLS #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new section to 'Configuring the CRD' with examples on how to disable the ingress and how to add a tls certificate to it. Issue jaegertracing#307 Signed-off-by: Cedric Kring <[email protected]>
|
@jpkrohling Would it be better to have the text as part of the "Accessing the Jaeger Console (UI) / Kubernetes" section - in the same way that the oauth proxy is documented in the OpenShift subsection? As this (I assume) is only relevant to Kubernetes rather than OpenShift? |
|
Yes, makes sense to me. |
Signed-off-by: Cedric Kring <[email protected]>
|
@jpkrohling I moved only the TLS part to the "Accessing the Jaeger UI" section. |
objectiser
approved these changes
Oct 9, 2019
Signed-off-by: Cedric Kring <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new section to 'Configuring the CRD' with examples on how to disable the Ingress and how to add a TLS certificate to it.
Issue #307
Relates to jaegertracing/jaeger-operator#681
Signed-off-by: Cedric Kring [email protected]