Use elasticsearch operator 4.2, add workflow for 4.1 #631
Conversation
|
@jpkrohling any idea why CI is failing? |
|
Probably because of actions/checkout#23. For the record, I'm currently seeing other CI failures as well, like timeouts to get code from |
|
We should build an image with the vendor deps and just mount it :) |
pavolloffay
force-pushed
the
es-operator-4.2
branch
from
ecb5be1 to
0e997f2
Compare
Signed-off-by: Pavol Loffay <[email protected]>
pavolloffay
force-pushed
the
es-operator-4.2
branch
from
0e997f2 to
a12ebcf
Compare
Signed-off-by: Pavol Loffay <[email protected]>
| TEST_GROUP: ${{ matrix.TEST_GROUP }} | ||
| ES_OPERATOR_BRANCH: release-4.1 | ||
| ES_OPERATOR_IMAGE: quay.io/openshift/origin-elasticsearch-operator:4.1 | ||
| run: ./.ci/run-e2e-tests.sh |
There was a problem hiding this comment.
Should it run all e2e tests here, or just the es ones?
There was a problem hiding this comment.
The original OCP workflow run es-self-provisioned test group. This file is just copied to run the same CI as before.
There was a problem hiding this comment.
@jpkrohling Thoughts - should it just be limited to run the self provisioned tests? and also update the other workflow aswell?
There was a problem hiding this comment.
@objectiser It seems like a separate issue/discussion. Could you please create an issue to discuss which tests should be run on OCP?
There was a problem hiding this comment.
should it just be limited to run the self provisioned tests? and also update the other workflow aswell?
Good question. I think I would still like to know if something is broken when using an externally managed ES. It might have been limited first for development purposes, and I probably forgot to enable it for the other tests.
There was a problem hiding this comment.
I am might be missing something, but it seems to me we are talking about different things here.
There is a test for externally managed elasticsearch - the group name is es. The question is whether we want to run it on openshift, at the moment we run it only on k8s.
I think externally managed elasticsearch test on openshift is not very important. However there might be other tests more suitable to run on Openshift e.g. test oauth proxy (I am not sure if there is such a test).
There was a problem hiding this comment.
Ok will open a separate issue.
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
|
I have addressed all comments. CI passed. |
Es operator 4.2 uses operator SDK
v0.7.0. I think we should keep copied ES CR model files to allows us to update SDK to newer versions e.g. #609Signed-off-by: Pavol Loffay [email protected]