Updated operator-sdk to 0.10.0 #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpkrohling
force-pushed
the
607-Update-Operator-SDK-to-0.10.0
branch
3 times, most recently
from
32489b5 to
58f49e0
Compare
jpkrohling
changed the title
|
Not sure if related to this change but I had to install |
|
Just to make sure, this PR should not be merged until after 1.14 of Jaeger and Jaeger Operator has been released. |
pavolloffay
reviewed
Aug 30, 2019
| @@ -18,7 +18,8 @@ KAFKA_NAMESPACE ?= "kafka" | |||
| ES_OPERATOR_NAMESPACE = openshift-logging | |||
| ES_OPERATOR_BRANCH ?= release-4.1 | |||
| ES_OPERATOR_IMAGE ?= quay.io/openshift/origin-elasticsearch-operator:4.1 | |||
| SDK_VERSION=v0.8.1 | |||
| SDK_VERSION=v0.10.0 | |||
| GOPATH ?= "$(HOME)/go" | |||
There was a problem hiding this comment.
Because of the installed tools. go get ... installs it under GOPATH/go/bin , and we use that later on when running golint/gosec.
jpkrohling
force-pushed
the
607-Update-Operator-SDK-to-0.10.0
branch
3 times, most recently
from
2be9a89 to
e057436
Compare
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
jpkrohling
force-pushed
the
607-Update-Operator-SDK-to-0.10.0
branch
from
e057436 to
e245572
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #607