-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resource limits for spark dependencies cronjob #620
Conversation
9397b27
to
76143e9
Compare
One of the e2e tests for Kubernetes failed, so I just restarted it. Almost immediately, I saw this in the logs:
Not sure what's going on, but could you try to rebase and update this PR? |
Opened actions/checkout#23 to track this failure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add a test?
pkg/cronjob/spark_dependencies.go
Outdated
@@ -68,7 +68,8 @@ func CreateSparkDependencies(jaeger *v1.Jaeger) *batchv1beta1.CronJob { | |||
Image: jaeger.Spec.Storage.Dependencies.Image, | |||
Name: name, | |||
// let spark job use its default values | |||
Env: removeEmptyVars(envVars), | |||
Env: removeEmptyVars(envVars), | |||
Resources: jaeger.Spec.Storage.Dependencies.Resources, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think other components by default use the resources specified at the root level of the spec. We should consider doing the same here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
3d81896
to
c41c003
Compare
Signed-off-by: Ruben Vargas <[email protected]>
@pavolloffay Tests added. |
@rubenvp8510 could you please share an example of how a Jaeger resource would look like (yaml)? I am not sure about how the golang I am particularly interested in increasing the request/limits of the jaeger-spark-dependencies pods. The official docs omit the info about it in the "Configuring the Custom Resource" section. Thank you. |
Fixes #598