Skip to content

Commit

Permalink
add resource limits for spark dependencies cronjob
Browse files Browse the repository at this point in the history
Signed-off-by: Ruben Vargas <[email protected]>
  • Loading branch information
rubenvp8510 committed Aug 27, 2019
1 parent 1985254 commit 76143e9
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 1 deletion.
3 changes: 3 additions & 0 deletions pkg/apis/jaegertracing/v1/jaeger_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -376,6 +376,9 @@ type JaegerDependenciesSpec struct {

// +optional
TTLSecondsAfterFinished *int32 `json:"ttlSecondsAfterFinished,omitempty"`

// +optional
Resources v1.ResourceRequirements `json:"resources,omitempty"`
}

// JaegerEsIndexCleanerSpec holds the options related to es-index-cleaner
Expand Down
1 change: 1 addition & 0 deletions pkg/apis/jaegertracing/v1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion pkg/cronjob/spark_dependencies.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@ func CreateSparkDependencies(jaeger *v1.Jaeger) *batchv1beta1.CronJob {
Image: jaeger.Spec.Storage.Dependencies.Image,
Name: name,
// let spark job use its default values
Env: removeEmptyVars(envVars),
Env: removeEmptyVars(envVars),
Resources: jaeger.Spec.Storage.Dependencies.Resources,
},
},
RestartPolicy: corev1.RestartPolicyNever,
Expand Down

0 comments on commit 76143e9

Please sign in to comment.