Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label to the common spec #445

Merged
merged 1 commit into from
May 31, 2019
Merged

Add label to the common spec #445

merged 1 commit into from
May 31, 2019

Conversation

objectiser
Copy link
Contributor

Resolves #439

Signed-off-by: Gary Brown [email protected]

@objectiser objectiser requested a review from jpkrohling May 28, 2019 13:23
@codecov
Copy link

codecov bot commented May 28, 2019

Codecov Report

Merging #445 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #445      +/-   ##
==========================================
+ Coverage   91.11%   91.15%   +0.03%     
==========================================
  Files          64       64              
  Lines        3130     3142      +12     
==========================================
+ Hits         2852     2864      +12     
  Misses        196      196              
  Partials       82       82
Impacted Files Coverage Δ
pkg/apis/jaegertracing/v1/jaeger_types.go 100% <ø> (ø) ⬆️
pkg/deployment/query.go 100% <100%> (ø) ⬆️
pkg/util/util.go 100% <100%> (ø) ⬆️
pkg/deployment/all-in-one.go 100% <100%> (ø) ⬆️
pkg/deployment/collector.go 100% <100%> (ø) ⬆️
pkg/deployment/ingester.go 100% <100%> (ø) ⬆️
pkg/ingress/query.go 100% <100%> (ø) ⬆️
pkg/deployment/agent.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18d5077...d5cacc8. Read the comment docs.

Copy link
Contributor

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom annotation/labels
2 participants