Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom annotation/labels #439

Closed
arnitolog opened this issue May 27, 2019 · 4 comments · Fixed by #445
Closed

Custom annotation/labels #439

arnitolog opened this issue May 27, 2019 · 4 comments · Fixed by #445

Comments

@arnitolog
Copy link

Hello,

is there any way to set custom annotation and label for kind:Ingress. I need to do this in order to provide a type of the ingress controller and type of traffic (internal/external) to our kubernetes cluster.

@objectiser
Copy link
Contributor

You can define annotations against the ingress:

apiVersion: jaegertracing.io/v1
kind: Jaeger
metadata:
  name: my-ingress
spec:
  ingress:
    annotations:
      key1: value1

However currently labels are not configurable. Could you provide an example of the type of annotations/labels you are looking to provide? Are they specific to your use case or generally required?

@arnitolog
Copy link
Author

Thanks for the reply. Here is a use case for labels:
we have 2 different types of ingress controllers: Internal - not internet facing and External which can be reached form the Internet.
And when I describe my ingress I need to provide a label "traffic-type" which can be internal or external depending on what kind of access I want to provide.

@objectiser
Copy link
Contributor

@jpkrohling Any objections to labels being added to the common spec?

@jpkrohling
Copy link
Contributor

No objections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants