Create metrics service only when running in k8s cluster #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <[email protected]>
pavolloffay
commented
May 28, 2019
| log.Fatal(err) | ||
| } else if operatorService != nil { |
There was a problem hiding this comment.
This check was missing there. The ExposeMetricsPort returns nil, nil if the code does not run inside the k8s cluster.
Codecov Report
@@ Coverage Diff @@
## master #444 +/- ##
=======================================
Coverage 91.11% 91.11%
=======================================
Files 64 64
Lines 3130 3130
=======================================
Hits 2852 2852
Misses 196 196
Partials 82 82Continue to review full report at Codecov.
|
objectiser
approved these changes
May 28, 2019
pkg/cmd/start/main.go
Outdated
| log.Fatal(err) | ||
| } else if operatorService != nil { | ||
| err = setOwnerReference(operatorService) |
There was a problem hiding this comment.
minor point: could be if err = setOwnerReference(operatorService); err != nil {
Signed-off-by: Pavol Loffay <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #441
Signed-off-by: Pavol Loffay [email protected]