Create metrics service only when running in k8s cluster (#444)

* Create metrics service only when running in k8s cluster Signed-off-by: Pavol Loffay <[email protected]> * use if style Signed-off-by: Pavol Loffay <[email protected]>
jaegertracing · May 28, 2019 · 5c61e4e · 5c61e4e
1 parent 18d5077
commit 5c61e4e
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/pkg/cmd/start/main.go b/pkg/cmd/start/main.go
@@ -182,11 +182,13 @@ func start(cmd *cobra.Command, args []string) {
 	}
 
 	// Create Service object to expose the metrics port.
-	var operatorService *corev1.Service
-	if operatorService, err = metrics.ExposeMetricsPort(ctx, viper.GetInt32("metrics-port")); err != nil {
-		log.Fatal(err)
-	} else if err = setOwnerReference(operatorService); err != nil {
+	operatorService, err := metrics.ExposeMetricsPort(ctx, viper.GetInt32("metrics-port"))
+	if err != nil {
 		log.Fatal(err)
+	} else if operatorService != nil {
+		if err := setOwnerReference(operatorService); err != nil {
+			log.Fatal(err)
+		}
 	}
 
 	// Start the Cmd