Revert "Add streaming e2e tests" #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8cfd02e. Signed-off-by: Gary Brown <[email protected]>
objectiser
force-pushed
the
revert-391-streame2e
branch
from
38e2d08 to
c772736
Compare
Codecov Report
@@ Coverage Diff @@
## master #392 +/- ##
=======================================
Coverage 89.71% 89.71%
=======================================
Files 64 64
Lines 3092 3092
=======================================
Hits 2774 2774
Misses 216 216
Partials 102 102Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #391
One issue I found was the suite test is
TestElasticsearchwhich is not unique within the package, and seemed to cause the re-run of the es e2e tests to try using streaming. So needs further investigation.