-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add streaming e2e tests #391
Conversation
Signed-off-by: Gary Brown <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #391 +/- ##
=======================================
Coverage 89.71% 89.71%
=======================================
Files 64 64
Lines 3092 3092
=======================================
Hits 2774 2774
Misses 216 216
Partials 102 102 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK, pending a verification about the volume claim size :)
version: 2.1.0 | ||
replicas: 1 | ||
listeners: | ||
plain: {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are those empty nodes required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Theses are a straight copy from the strimzi installation instructions - aiming to keep things straightforward, so periodically we can update to more recent versions.
log.message.format.version: "2.1" | ||
storage: | ||
type: persistent-claim | ||
size: 100Gi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
O_O
I hope it won't create a 100Gi volume?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I was just afraid it would create a real 100Gi volume :-) If it doesn't, it's all good then
This reverts commit 8cfd02e.
This reverts commit 8cfd02e. Signed-off-by: Gary Brown <[email protected]>
This reverts commit 8cfd02e. Signed-off-by: Gary Brown <[email protected]>
Signed-off-by: Gary Brown [email protected]