Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add streaming e2e tests #391

Merged
merged 1 commit into from
May 3, 2019
Merged

Add streaming e2e tests #391

merged 1 commit into from
May 3, 2019

Conversation

objectiser
Copy link
Contributor

Signed-off-by: Gary Brown [email protected]

Signed-off-by: Gary Brown <[email protected]>
@codecov
Copy link

codecov bot commented May 3, 2019

Codecov Report

Merging #391 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #391   +/-   ##
=======================================
  Coverage   89.71%   89.71%           
=======================================
  Files          64       64           
  Lines        3092     3092           
=======================================
  Hits         2774     2774           
  Misses        216      216           
  Partials      102      102

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc63d2b...5a81923. Read the comment docs.

@objectiser objectiser changed the title WIP: Add streaming e2e tests Add streaming e2e tests May 3, 2019
Copy link
Contributor

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, pending a verification about the volume claim size :)

version: 2.1.0
replicas: 1
listeners:
plain: {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are those empty nodes required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theses are a straight copy from the strimzi installation instructions - aiming to keep things straightforward, so periodically we can update to more recent versions.

log.message.format.version: "2.1"
storage:
type: persistent-claim
size: 100Gi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O_O
I hope it won't create a 100Gi volume?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I was just afraid it would create a real 100Gi volume :-) If it doesn't, it's all good then

@objectiser objectiser merged commit 8cfd02e into jaegertracing:master May 3, 2019
@objectiser objectiser deleted the streame2e branch May 3, 2019 15:41
objectiser added a commit that referenced this pull request May 3, 2019
objectiser added a commit that referenced this pull request May 3, 2019
This reverts commit 8cfd02e.

Signed-off-by: Gary Brown <[email protected]>
objectiser added a commit that referenced this pull request May 3, 2019
This reverts commit 8cfd02e.

Signed-off-by: Gary Brown <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants