Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the autoclean tasks to their own module #2276

Merged
merged 5 commits into from
Aug 4, 2023

Conversation

iblancasa
Copy link
Collaborator

Which problem is this PR solving?

Short description of the changes

  • Create the autoclean module
    Some stuff used by the autoclean module is using viper. To avoid a cycle, I moved this logic outsed the autodetect module (since actually we were not autodetecting anything in this case).

@iblancasa iblancasa self-assigned this Jul 28, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 28, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Patch coverage: 40.96% and project coverage change: +0.28% 🎉

Comparison is base (b98428c) 87.12% compared to head (068d543) 87.41%.

❗ Current head 068d543 differs from pull request most recent head 896c35c. Consider uploading reports for the commit 896c35c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2276      +/-   ##
==========================================
+ Coverage   87.12%   87.41%   +0.28%     
==========================================
  Files         100      101       +1     
  Lines        7068     7006      -62     
==========================================
- Hits         6158     6124      -34     
+ Misses        706      677      -29     
- Partials      204      205       +1     
Files Changed Coverage Δ
pkg/autodetect/main.go 96.37% <ø> (+19.93%) ⬆️
pkg/autoclean/main.go 40.96% <40.96%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iblancasa iblancasa marked this pull request as ready for review July 28, 2023 16:09
@iblancasa iblancasa requested a review from rubenvp8510 July 28, 2023 16:09
@iblancasa
Copy link
Collaborator Author

/retest-required

@rubenvp8510 rubenvp8510 merged commit fb1078c into jaegertracing:main Aug 4, 2023
@iblancasa iblancasa deleted the bug/1983-2 branch August 7, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants