Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the autodetect module to reduce the number of writes/reads in viper configuration #2274

Merged
merged 3 commits into from
Jul 28, 2023

Conversation

iblancasa
Copy link
Collaborator

@iblancasa iblancasa commented Jul 27, 2023

Which problem is this PR solving?

Short description of the changes

  • Reduce the number of read/writes to viper in the different functions
  • The version of the autoscaling and cronjob APIs is checked just in the start

Note this is the first PR to fix the #1983 issue.

@iblancasa iblancasa added the bug Something isn't working label Jul 27, 2023
@iblancasa iblancasa requested a review from rubenvp8510 July 27, 2023 16:06
@iblancasa iblancasa self-assigned this Jul 27, 2023
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% 🎉

Comparison is base (021efc7) 87.66% compared to head (3b60e3c) 87.68%.

❗ Current head 3b60e3c differs from pull request most recent head 1671d77. Consider uploading reports for the commit 1671d77 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2274      +/-   ##
==========================================
+ Coverage   87.66%   87.68%   +0.02%     
==========================================
  Files         100      100              
  Lines        6973     6985      +12     
==========================================
+ Hits         6113     6125      +12     
  Misses        656      656              
  Partials      204      204              
Files Changed Coverage Δ
pkg/autodetect/main.go 86.66% <100.00%> (+0.65%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iblancasa
Copy link
Collaborator Author

/retest

@rubenvp8510 rubenvp8510 merged commit efe0d36 into jaegertracing:main Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants