feat: added pathType to ingress #2066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giautm
force-pushed
the
giautm/path-type
branch
5 times, most recently
from
f58eb3f to
d8c7a93
Compare
giautm
force-pushed
the
giautm/path-type
branch
from
d8c7a93 to
5f3c16e
Compare
|
thats awesome, thanks @giautm. I will have a more detailed look later today. |
giautm
force-pushed
the
giautm/path-type
branch
2 times, most recently
from
f490593 to
2fd0dc0
Compare
Signed-off-by: Giau. Tran Minh <[email protected]>
Signed-off-by: Giau. Tran Minh <[email protected]>
giautm
force-pushed
the
giautm/path-type
branch
from
2fd0dc0 to
84c7299
Compare
|
Seems some formating is wrong. |
Signed-off-by: Giau. Tran Minh <[email protected]>
giautm
force-pushed
the
giautm/path-type
branch
from
1ff071b to
86a236e
Compare
|
Hello @frzifus , review again please? |
Codecov ReportBase: 87.29% // Head: 87.30% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2066 +/- ##
=======================================
Coverage 87.29% 87.30%
=======================================
Files 100 100
Lines 6826 6828 +2
=======================================
+ Hits 5959 5961 +2
Misses 665 665
Partials 202 202
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
rubenvp8510
pushed a commit
to rubenvp8510/jaeger-operator
that referenced
this pull request
Sep 19, 2022
* feat: added pathType to ingress Signed-off-by: Giau. Tran Minh <[email protected]> * fix: update bundle Signed-off-by: Giau. Tran Minh <[email protected]> * fix: run make format Signed-off-by: Giau. Tran Minh <[email protected]> Signed-off-by: Giau. Tran Minh <[email protected]>
|
Hello @frzifus, can you create another release for helm-chart, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
pathTypetoingress