Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Support for path / pathType in query ingress #2065

Closed
giautm opened this issue Sep 15, 2022 · 4 comments · Fixed by #2066
Closed

[Feature]: Support for path / pathType in query ingress #2065

giautm opened this issue Sep 15, 2022 · 4 comments · Fixed by #2066
Assignees
@giautm
Labels
enhancement New feature or request

Comments

@giautm
Copy link
Contributor

giautm commented Sep 15, 2022 •
edited
Loading

Requirement

I want able to change the ingress config for the query service to setting path to / and pathType to Prefix. So, I don't have to create the custom ingress for the query service.

Problem

Currently, I unable to setting path and pathType for the query ingress.

Proposal

No response

Open questions

No response
@giautm giautm added the enhancement New feature or request label Sep 15, 2022
@frzifus
Copy link
Member

frzifus commented Sep 16, 2022

Hi @giautm are you interested in contributing this?

@giautm
Copy link
Contributor Author

giautm commented Sep 16, 2022

Hi @giautm are you interested in contributing this?

Ofcourse, let's me try. 🖖

@frzifus
Copy link
Member

frzifus commented Sep 16, 2022

awesome :)

@giautm giautm mentioned this issue Sep 16, 2022
Merged
@giautm
Copy link
Contributor Author

giautm commented Sep 16, 2022

Hey @frzifus, can you please review #2066? This is the first PR for this project, so please guide me. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@giautm giautm

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: added pathType to ingress giautm/jaeger-operator
2 participants
@frzifus @giautm