Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify namespace permissions before adding ns controller #1914

Merged
merged 8 commits into from
May 31, 2022
Merged

Verify namespace permissions before adding ns controller #1914

Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c06036c
verify namespace permissions before adding ns controller
rubenvp8510 May 29, 2022
474e2be
Merge branch 'main' into Issue-1894
rubenvp8510 May 29, 2022
16cd96f
change log level when ns controller is disabled
rubenvp8510 May 30, 2022
3c263fa
Merge branch 'main' into Issue-1894
rubenvp8510 May 30, 2022
e1b5f0e
Merge branch 'main' into Issue-1894
rubenvp8510 May 30, 2022
f1a091c
Merge branch 'main' into Issue-1894
rubenvp8510 May 30, 2022
54d89f0
Merge branch 'main' into Issue-1894
rubenvp8510 May 31, 2022
39b7fde
Merge branch 'main' into Issue-1894
rubenvp8510 May 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions pkg/cmd/start/bootstrap.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,9 +356,13 @@ func setupControllers(ctx context.Context, mgr manager.Manager) {
os.Exit(1)
}

if err := appsv1controllers.NewNamespaceReconciler(client, clientReader, schema).SetupWithManager(mgr); err != nil {
setupLog.Error(err, "unable to create controller", "controller", "Namespace")
os.Exit(1)
if viper.GetBool(v1.ConfigEnableNamespaceController) {
if err := appsv1controllers.NewNamespaceReconciler(client, clientReader, schema).SetupWithManager(mgr); err != nil {
setupLog.Error(err, "unable to create controller", "controller", "Namespace")
os.Exit(1)
}
} else {
log.Warn("skipping reconciliation for namespaces, do not have permissions to list and watch namespaces")
}

if err := esv1controllers.NewReconciler(client, clientReader).SetupWithManager(mgr); err != nil {
Expand Down