Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify namespace permissions before adding ns controller #1914

Merged
merged 8 commits into from
May 31, 2022

Conversation

rubenvp8510
Copy link
Collaborator

@rubenvp8510 rubenvp8510 commented May 29, 2022

Signed-off-by: Ruben Vargas [email protected]

Which problem is this PR solving?

Short description of the changes

  • Before adding namespace controller we need to check the permissions, if not namespace controller will be added and prevent the operator to start in non cluster-wide mode.

@rubenvp8510
Copy link
Collaborator Author

@frzifus Could you review?

Thanks

@codecov
Copy link

codecov bot commented May 29, 2022

Codecov Report

Merging #1914 (54d89f0) into main (5044aa9) will not change coverage.
The diff coverage is n/a.

❗ Current head 54d89f0 differs from pull request most recent head 39b7fde. Consider uploading reports for the commit 39b7fde to get more accurate results

@@           Coverage Diff           @@
##             main    #1914   +/-   ##
=======================================
  Coverage   88.25%   88.25%           
=======================================
  Files         100      100           
  Lines        6303     6303           
=======================================
  Hits         5563     5563           
  Misses        543      543           
  Partials      197      197           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e17fa17...39b7fde. Read the comment docs.

frzifus
frzifus previously approved these changes May 29, 2022
pkg/cmd/start/bootstrap.go Outdated Show resolved Hide resolved
@rubenvp8510 rubenvp8510 merged commit 829ecae into jaegertracing:main May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Namespace controller try to watch on non-cluster wide mode
2 participants