Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kafkaSecretName for collector and ingester #1910

Merged

Conversation

luohua13
Copy link
Contributor

@luohua13 luohua13 commented May 27, 2022

Which problem is this PR solving?

Resolves #1422

Short description of the changes

Add kafkaSecretName for collctor and ingester

@luohua13 luohua13 force-pushed the add-support-for-kafka-secrets branch 2 times, most recently from 27bb787 to 0975f98 Compare May 27, 2022 08:49
@luohua13 luohua13 force-pushed the add-support-for-kafka-secrets branch from f4eb3c3 to e2bc1dc Compare May 27, 2022 09:30
@rubenvp8510
Copy link
Collaborator

@luohua13 CI is complaining about format issue, Could you fix it? other than that the PR LGTM.

@luohua13
Copy link
Contributor Author

luohua13 commented Jun 5, 2022

@luohua13 CI is complaining about format issue, Could you fix it? other than that the PR LGTM.

ok, I will fix it.

@luohua13 luohua13 force-pushed the add-support-for-kafka-secrets branch from 6555594 to 095adc3 Compare June 5, 2022 13:17
@rubenvp8510 rubenvp8510 enabled auto-merge (squash) June 5, 2022 17:12
@rubenvp8510
Copy link
Collaborator

@luohua13 CI is complaining about format issue, Could you fix it? other than that the PR LGTM.

ok, I will fix it.

Thank you! 🎉

@codecov
Copy link

codecov bot commented Jun 5, 2022

Codecov Report

Merging #1910 (c6ac14a) into main (37e185c) will decrease coverage by 0.09%.
The diff coverage is 50.00%.

❗ Current head c6ac14a differs from pull request most recent head 10c7d6f. Consider uploading reports for the commit 10c7d6f to get more accurate results

@@            Coverage Diff             @@
##             main    #1910      +/-   ##
==========================================
- Coverage   88.26%   88.17%   -0.10%     
==========================================
  Files         100      100              
  Lines        6307     6323      +16     
==========================================
+ Hits         5567     5575       +8     
- Misses        543      550       +7     
- Partials      197      198       +1     
Impacted Files Coverage Δ
apis/v1/jaeger_types.go 87.50% <ø> (ø)
pkg/deployment/ingester.go 94.44% <0.00%> (-5.56%) ⬇️
pkg/deployment/collector.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37e185c...10c7d6f. Read the comment docs.

@luohua13
Copy link
Contributor Author

luohua13 commented Jun 7, 2022

@rubenvp8510 Can you review it again? And then merge it?

@rubenvp8510 rubenvp8510 merged commit 1ddce73 into jaegertracing:main Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support passing Kafka username/password as K8S secrets
3 participants