-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add kafkaSecretName for collector and ingester #1910
add kafkaSecretName for collector and ingester #1910
Conversation
27bb787
to
0975f98
Compare
f4eb3c3
to
e2bc1dc
Compare
Signed-off-by: [email protected] <[email protected]>
@luohua13 CI is complaining about format issue, Could you fix it? other than that the PR LGTM. |
ok, I will fix it. |
Signed-off-by: [email protected] <[email protected]>
6555594
to
095adc3
Compare
Thank you! 🎉 |
Codecov Report
@@ Coverage Diff @@
## main #1910 +/- ##
==========================================
- Coverage 88.26% 88.17% -0.10%
==========================================
Files 100 100
Lines 6307 6323 +16
==========================================
+ Hits 5567 5575 +8
- Misses 543 550 +7
- Partials 197 198 +1
Continue to review full report at Codecov.
|
@rubenvp8510 Can you review it again? And then merge it? |
Which problem is this PR solving?
Resolves #1422
Short description of the changes
Add kafkaSecretName for collctor and ingester