Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing Kafka username/password as K8S secrets #1422

Closed
tonychoe opened this issue Apr 2, 2021 · 3 comments · Fixed by #1910
Closed

Support passing Kafka username/password as K8S secrets #1422

tonychoe opened this issue Apr 2, 2021 · 3 comments · Fixed by #1910
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@tonychoe
Copy link

tonychoe commented Apr 2, 2021

Problem to Solve

I am using the existing Kafka for the streaming strategy. Looks like there's no option to pass the Kafka username/password as K8S secret to jaeger-collector and ingester. It would be good to support it.

Proposed Solution
Passing the Kafka username/password as a K8S secret.

More info
This is my current config in Jsonnet. It passed the username/password as the container args which lacks protection.

    topic: "jaeger-spans",
    brokers: "cell-1.streaming.us-phoenix-1.oci.oraclecloud.com:9092",
    authentication: "plaintext",
    plaintext: {
      username: $.streaming_username,
      password: $.streaming_password,
    },
    "protocol-version": "2.1.1",
    tls: {
      enabled: true,
    },

Before trying Jaeger Operator, I used to handle them as env vars.

        env:
          - name: KAFKA_CONSUMER_PLAINTEXT_USERNAME
            valueFrom:
              secretKeyRef:
                key: username
                name: jaegerkafkaauth
          - name: KAFKA_CONSUMER_PLAINTEXT_PASSWORD
            valueFrom:
              secretKeyRef:
                key: password
                name: jaegerkafkaauth
@github-actions github-actions bot added the needs-triage New issues, in need of classification label Apr 2, 2021
@tonychoe tonychoe changed the title Support Kafka username/password as K8S secret Support passing Kafka username/password as K8S secrets Apr 2, 2021
@jpkrohling jpkrohling added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed and removed needs-triage New issues, in need of classification labels Apr 6, 2021
@jpkrohling
Copy link
Contributor

I think we have the same problem with storage mechanisms as well. It would be good to have this feature for usernames/passwords in general.

@dimitraz
Copy link

dimitraz commented Oct 2, 2021

Hey @jpkrohling, is this still available? If so i'd love to help out as part of hacktoberfest :)

@luohua13
Copy link
Contributor

Hi @jpkrohling @dimitraz , I'll start working on this right away :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants