Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid touching jaeger deps on deployment/ns controller #1529

Merged

Conversation

rubenvp8510
Copy link
Collaborator

@rubenvp8510 rubenvp8510 commented Aug 11, 2021

Signed-off-by: Ruben Vargas [email protected]

Which problem is this PR solving?

Short description of the changes

  • There is a warning for query deployment trying to remove his own Sidecar, I don't want to overcomplicated the injection logic, instead I added a logic at the beginning of deployment and on the namespace controller to just ignore the Jaeger deployments. (label app="jaeger"). Said that I think this deserve a re-factorization, but for now this PR should fix it.

Hope the use of webhook in v2 will simplify a lot of things here.

@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #1529 (b19a46b) into master (68cc6ee) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

❗ Current head b19a46b differs from pull request most recent head 924a284. Consider uploading reports for the commit 924a284 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1529      +/-   ##
==========================================
- Coverage   87.72%   87.58%   -0.14%     
==========================================
  Files          93       94       +1     
  Lines        5866     5954      +88     
==========================================
+ Hits         5146     5215      +69     
- Misses        553      562       +9     
- Partials      167      177      +10     
Impacted Files Coverage Δ
pkg/controller/deployment/deployment_controller.go 53.79% <100.00%> (+23.72%) ⬆️
pkg/controller/namespace/namespace_controller.go 39.53% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68cc6ee...924a284. Read the comment docs.

@rubenvp8510
Copy link
Collaborator Author

@pavolloffay Could you please review?

@rubenvp8510 rubenvp8510 reopened this Sep 30, 2021
@rubenvp8510 rubenvp8510 force-pushed the Issue-inject-sidecar-jaeger branch from dec62e1 to 924a284 Compare September 30, 2021 23:39
@rubenvp8510 rubenvp8510 merged commit 5614ac6 into jaegertracing:master Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Operator tried to delete jaeger-query sidecar
2 participants