Implement backoff limit for jobs

[chasekiefer]

Resolves #1424

Short description of the changes

• Add optional BackoffLimit to JaegerEsIndexCleanerSpec
• Add optional BackoffLimit to JaegerEsIndexCleanerSpec
• Add optional BackoffLimit to JaegerEsRolloverSpec
• Update es_index_cleaner.go CreateEsIndexCleaner function with BackoffLimit
• Update es_rollover rollover function with BackoffLimit
• Update spark_dependencies.go CreateSparkDependencies function with BackoffLimit
• TestEsIndexCleanerBackoffLimit
• TestEsRolloverBackoffLimit
• Add TestSparkDependenciesBackoffLimit

[jpkrohling]

Looks good, but you might need to run make generate, the build is failing with:

Formatting code...
pkg/cronjob/es_rollover.go
pkg/cronjob/spark_dependencies.go
Build failed: a model has been changed but the generated resources aren't up to date. Run 'make generate' and update your PR.

[jpkrohling]

Looks good, just need to figure out the CI failure

[codecov]

Codecov Report

Merging #1468 (7368967) into master (86a9284) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1468   +/-   ##
=======================================
  Coverage   87.15%   87.16%           
=======================================
  Files          90       90           
  Lines        4983     4986    +3     
=======================================
+ Hits         4343     4346    +3     
  Misses        484      484           
  Partials      156      156           

Impacted Files	Coverage Δ
pkg/apis/jaegertracing/v1/jaeger_types.go	100.00% <ø> (ø)
pkg/cronjob/es_index_cleaner.go	100.00% <100.00%> (ø)
pkg/cronjob/es_rollover.go	95.68% <100.00%> (+0.03%)	⬆️
pkg/cronjob/spark_dependencies.go	93.20% <100.00%> (+0.06%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86a9284...7368967. Read the comment docs.

[chasekiefer]

Looks good, just need to figure out the CI failure

It looks like it timed out on 02-check-ingress.yaml. Is there anything I can do to help resolve this? Maybe it was just a one-off issue with the e2e test.

[jpkrohling]

I'm re-running the jobs, but if this fails again, we'll go forward with the 1.23 release and sort this out later.