Our k8s provider mandates the use of backoffLimit <=3.

[arjuncreativo]

How can I set backoffLimit for storage type elasticsearch under esIndexCleaner and dependencies

time="2021-04-05T08:05:30Z" level=error msg="failed to apply the changes" error="admission webhook \"xxxxxx.webhook\" denied the request: Job spec in CronJob must set 'backoffLimit' <= 3" execution="2021-04-05 08:05:30.031265563 +0000 UTC" instance=jaeger-tracing-prd namespace=xxxxxxxxx

[jpkrohling]

Seems like a good first issue. Would you like to send a PR for this? You'd need to change this struct to accommodate the new field:

jaeger-operator/pkg/apis/jaegertracing/v1/jaeger_types.go

Lines 603 to 624 in 65490e8

	type JaegerEsIndexCleanerSpec struct {
	// +optional
	Enabled *bool `json:"enabled,omitempty"`
	// +optional
	NumberOfDays *int `json:"numberOfDays,omitempty"`
	// +optional
	Schedule string `json:"schedule,omitempty"`
	// +optional
	SuccessfulJobsHistoryLimit *int32 `json:"successfulJobsHistoryLimit,omitempty"`
	// +optional
	Image string `json:"image,omitempty"`
	// +optional
	TTLSecondsAfterFinished *int32 `json:"ttlSecondsAfterFinished,omitempty"`
	// +optional
	JaegerCommonSpec `json:",inline,omitempty"`
	}

Make sure to add the same field to other places that also create cronjobs, such as the JaegerDependenciesSpec and JaegerCassandraCreateSchemaSpec.

You'll then be able to use it here:

jaeger-operator/pkg/cronjob/es_index_cleaner.go

Lines 48 to 99 in 65490e8

	return &batchv1beta1.CronJob{
	ObjectMeta: metav1.ObjectMeta{
	Name: name,
	Namespace: jaeger.Namespace,
	Labels: commonSpec.Labels,
	Annotations: commonSpec.Annotations,
	OwnerReferences: []metav1.OwnerReference{
	{
	APIVersion: jaeger.APIVersion,
	Kind: jaeger.Kind,
	Name: jaeger.Name,
	UID: jaeger.UID,
	Controller: &trueVar,
	},
	},
	},
	Spec: batchv1beta1.CronJobSpec{
	Schedule: jaeger.Spec.Storage.EsIndexCleaner.Schedule,
	SuccessfulJobsHistoryLimit: jaeger.Spec.Storage.EsIndexCleaner.SuccessfulJobsHistoryLimit,
	JobTemplate: batchv1beta1.JobTemplateSpec{
	Spec: batchv1.JobSpec{
	Parallelism: &one,
	TTLSecondsAfterFinished: jaeger.Spec.Storage.EsIndexCleaner.TTLSecondsAfterFinished,
	Template: corev1.PodTemplateSpec{
	Spec: corev1.PodSpec{
	Containers: []corev1.Container{
	{
	Name: util.Truncate(name, 63),
	Image: util.ImageName(jaeger.Spec.Storage.EsIndexCleaner.Image, "jaeger-es-index-cleaner-image"),
	Args: []string{strconv.Itoa(*jaeger.Spec.Storage.EsIndexCleaner.NumberOfDays), esUrls},
	Env: util.RemoveEmptyVars(envs),
	EnvFrom: envFromSource,
	Resources: commonSpec.Resources,
	VolumeMounts: commonSpec.VolumeMounts,
	},
	},
	RestartPolicy: corev1.RestartPolicyNever,
	Affinity: commonSpec.Affinity,
	Tolerations: commonSpec.Tolerations,
	SecurityContext: commonSpec.SecurityContext,
	ServiceAccountName: account.JaegerServiceAccountFor(jaeger, account.EsIndexCleanerComponent),
	Volumes: commonSpec.Volumes,
	},
	ObjectMeta: metav1.ObjectMeta{
	Labels: commonSpec.Labels,
	Annotations: commonSpec.Annotations,
	},
	},
	},
	},
	},
	}

Make sure to add a test and docs for this.

[chasekiefer]

I'm giving this a try and am looking to finish up by modifying the docs. Should I open a separate PR into the documentation repository?

[jpkrohling]

Yes, please create a new PR for the docs repo, linking to this PR here. The changes there should be applied only to the next-release directory. Thanks!

[chasekiefer]

@jpkrohling So I've been working through writing the docs but it appears https://www.jaegertracing.io/docs/1.22/operator/ doesn’t dive very deep into the CRD options. It seems like only pretty high-level features are mentioned. Does this deserve a mention in the docs?

[jpkrohling]

Right, sorry, it should probably be kept only as a godoc in the relevant Go type. We'll eventually figure out a way to properly document the whole CRD based on that.

[chasekiefer]

I added the godoc but I had to open a new PR. It should be good to go now!