Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backoffLimit for es_index_cleaner es_rollover spark_dependencies #1462

Closed
wants to merge 5 commits into from

Conversation

chasekiefer
Copy link
Contributor

Signed-off-by: Chase Kiefer [email protected]

Resolves #1424

Short description of the changes

  • Add optional BackoffLimit to JaegerEsIndexCleanerSpec
  • Add optional BackoffLimit to JaegerEsIndexCleanerSpec
  • Add optional BackoffLimit to JaegerEsRolloverSpec
  • Update es_index_cleaner.go CreateEsIndexCleaner function with BackoffLimit
  • Update es_rollover rollover function with BackoffLimit
  • Update spark_dependencies.go CreateSparkDependencies function with BackoffLimit
  • TestEsIndexCleanerBackoffLimit
  • TestEsRolloverBackoffLimit
  • Add TestSparkDependenciesBackoffLimit

@jpkrohling jpkrohling requested a review from rubenvp8510 June 3, 2021 10:11
@codecov
Copy link

codecov bot commented Jun 3, 2021

Codecov Report

Merging #1462 (0f4abca) into master (b83facc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 0f4abca differs from pull request most recent head c762041. Consider uploading reports for the commit c762041 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1462   +/-   ##
=======================================
  Coverage   86.88%   86.89%           
=======================================
  Files          91       91           
  Lines        5071     5074    +3     
=======================================
+ Hits         4406     4409    +3     
  Misses        510      510           
  Partials      155      155           
Impacted Files Coverage Δ
pkg/apis/jaegertracing/v1/jaeger_types.go 100.00% <ø> (ø)
pkg/cronjob/es_index_cleaner.go 100.00% <100.00%> (ø)
pkg/cronjob/es_rollover.go 95.68% <100.00%> (+0.03%) ⬆️
pkg/cronjob/spark_dependencies.go 93.20% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b83facc...c762041. Read the comment docs.

@chasekiefer chasekiefer closed this Jun 8, 2021
@chasekiefer chasekiefer deleted the 1424 branch June 8, 2021 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Our k8s provider mandates the use of backoffLimit <=3.
1 participant