Promote crd to apiextensions.k8s.io/v1 #1456

rubenvp8510 · 2021-05-19T05:39:42Z

Signed-off-by: Ruben Vargas [email protected]

This might break compatibility with k8s < 1.19, but is a necessary step to support k8s 1.22+

https://kubernetes.io/docs/reference/using-api/deprecation-guide/#v1-22

codecov · 2021-05-19T05:46:34Z

Codecov Report

Merging #1456 (f6347b3) into master (f7cee05) will increase coverage by 0.44%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##           master    #1456      +/-   ##
==========================================
+ Coverage   86.88%   87.33%   +0.44%     
==========================================
  Files          91       90       -1     
  Lines        5071     4982      -89     
==========================================
- Hits         4406     4351      -55     
+ Misses        510      478      -32     
+ Partials      155      153       -2

Impacted Files	Coverage Δ
pkg/autodetect/main.go	`86.13% <ø> (+4.49%)`	⬆️
pkg/strategy/strategy.go	`95.58% <ø> (ø)`
pkg/controller/jaeger/ingress.go	`74.19% <20.00%> (-0.81%)`	⬇️
pkg/ingress/query.go	`100.00% <100.00%> (ø)`
pkg/inventory/ingress.go	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7cee05...f6347b3. Read the comment docs.

jpkrohling

LGTM, but just to confirm: did you try this in OpenShift as well?

pavolloffay · 2021-05-19T12:54:23Z

Makefile

@@ -393,7 +393,7 @@ install-tools:
 		golang.org/x/lint/golint \
 		golang.org/x/tools/cmd/goimports \
 		github.com/securego/gosec/cmd/[email protected] \
-		sigs.k8s.io/controller-tools/cmd/controller-gen@v0.3.0 \
+		sigs.k8s.io/controller-tools/cmd/controller-gen@v0.5.0 \


Did bumping this version update the CRD yamls?

or did you run any command to generate CRD yalms?

I ran the controller-gen command and it generates the new CRD with the version.

rubenvp8510 · 2021-05-19T16:54:24Z

LGTM, but just to confirm: did you try this in OpenShift as well?

Tested with CRC and all-in-one strategy and it works .

jpkrohling · 2021-05-21T15:22:44Z

I think I restarted the tests a couple of times already. If this fails again, it might be a real failure, @rubenvp8510

rubenvp8510 · 2021-05-21T15:41:19Z

I think I restarted the tests a couple of times already. If this fails again, it might be a real failure, @rubenvp8510

Yes, I was investigating about the failures, it seems like I need to migrate the Ingress API too, and because of that I need to bump some versions of the libraries, specifically k8s.io/api. I'll request your review again once I finish.

Signed-off-by: Ruben Vargas <[email protected]>

pavolloffay

LGTM,

does this PR break compatibility with older k8s clusters?

pavolloffay · 2021-06-03T11:58:42Z

.github/workflows/e2e-kubernetes.yaml

+    - uses: actions/[email protected]
+    - name: "setup docker"
+      run: ./.ci/setup-docker.sh
+    - uses: manusa/[email protected]


nice I didn't see this. In the future we could also consider using kind.

Indeed, the new e2e tests are using kind and kuttl :-)

rubenvp8510 · 2021-06-03T15:27:30Z

LGTM,

does this PR break compatibility with older k8s clusters?

Yes :( 1.19+ is required.

rubenvp8510 force-pushed the crd-to-v1 branch 2 times, most recently from 2151eb0 to bf5f45e Compare May 19, 2021 05:42

rubenvp8510 requested review from jpkrohling and pavolloffay May 19, 2021 05:42

jpkrohling approved these changes May 19, 2021

View reviewed changes

jpkrohling enabled auto-merge (squash) May 19, 2021 10:01

pavolloffay reviewed May 19, 2021

View reviewed changes

rubenvp8510 force-pushed the crd-to-v1 branch from bf5f45e to 09757ce Compare May 19, 2021 16:53

rubenvp8510 force-pushed the crd-to-v1 branch from 09757ce to 8e37f03 Compare May 19, 2021 20:37

rubenvp8510 force-pushed the crd-to-v1 branch 12 times, most recently from 6f98ffe to 9dcce55 Compare May 25, 2021 17:15

rubenvp8510 disabled auto-merge May 25, 2021 20:53

rubenvp8510 force-pushed the crd-to-v1 branch 2 times, most recently from 8e383b7 to 7545013 Compare May 25, 2021 21:19

rubenvp8510 added 2 commits May 26, 2021 19:54

Promote crd to apiextensions.k8s.io/v1

2493d79

Signed-off-by: Ruben Vargas <[email protected]>

Migrate ingress api to networking/v1

4996968

Signed-off-by: Ruben Vargas <[email protected]>

rubenvp8510 added 4 commits May 26, 2021 20:04

Fix unit tests

c2ade15

Signed-off-by: Ruben Vargas <[email protected]>

Generate crd

b679042

Signed-off-by: Ruben Vargas <[email protected]>

Fix generate tests failure

5ff0072

Signed-off-by: Ruben Vargas <[email protected]>

bump minikube and kubernetes versions

a442d2d

Signed-off-by: Ruben Vargas <[email protected]>

rubenvp8510 force-pushed the crd-to-v1 branch 6 times, most recently from 7268950 to e329846 Compare May 31, 2021 15:31

rubenvp8510 requested review from pavolloffay and kevinearls May 31, 2021 17:00

rubenvp8510 force-pushed the crd-to-v1 branch from e329846 to eaa08ea Compare May 31, 2021 21:05

More fixes for ingress

8d3dc4e

Signed-off-by: Ruben Vargas <[email protected]>

rubenvp8510 force-pushed the crd-to-v1 branch from eaa08ea to 8d3dc4e Compare May 31, 2021 21:07

Update minikube github action and ubuntu

9143276

Signed-off-by: Ruben Vargas <[email protected]>

rubenvp8510 force-pushed the crd-to-v1 branch from 60568ef to 9143276 Compare June 1, 2021 00:46

Merge branch 'master' into crd-to-v1

3c72e02

rubenvp8510 force-pushed the crd-to-v1 branch 2 times, most recently from 913a2f3 to a5e39d0 Compare June 1, 2021 02:08

More minikube setup

1d56a29

Signed-off-by: Ruben Vargas <[email protected]>

rubenvp8510 force-pushed the crd-to-v1 branch from a5e39d0 to 1d56a29 Compare June 1, 2021 02:21

rubenvp8510 requested a review from jpkrohling June 1, 2021 02:46

pavolloffay approved these changes Jun 3, 2021

View reviewed changes

pavolloffay reviewed Jun 3, 2021

View reviewed changes

Merge branch 'master' into crd-to-v1

f6347b3

jpkrohling enabled auto-merge (squash) June 4, 2021 08:12

jpkrohling merged commit b601fc5 into jaegertracing:master Jun 4, 2021

lujiajing1126 mentioned this pull request Jun 25, 2021

Backwards support for old Kubernetes versions #1488

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Promote crd to apiextensions.k8s.io/v1 #1456

Promote crd to apiextensions.k8s.io/v1 #1456

rubenvp8510 commented May 19, 2021 •

edited

Loading

codecov bot commented May 19, 2021 •

edited

Loading

jpkrohling left a comment

pavolloffay May 19, 2021

pavolloffay May 19, 2021

rubenvp8510 May 19, 2021

rubenvp8510 commented May 19, 2021

jpkrohling commented May 21, 2021

rubenvp8510 commented May 21, 2021

pavolloffay left a comment

pavolloffay Jun 3, 2021

jpkrohling Jun 3, 2021

rubenvp8510 commented Jun 3, 2021

Promote crd to apiextensions.k8s.io/v1 #1456

Promote crd to apiextensions.k8s.io/v1 #1456

Conversation

rubenvp8510 commented May 19, 2021 • edited Loading

codecov bot commented May 19, 2021 • edited Loading

Codecov Report

jpkrohling left a comment

Choose a reason for hiding this comment

pavolloffay May 19, 2021

Choose a reason for hiding this comment

pavolloffay May 19, 2021

Choose a reason for hiding this comment

rubenvp8510 May 19, 2021

Choose a reason for hiding this comment

rubenvp8510 commented May 19, 2021

jpkrohling commented May 21, 2021

rubenvp8510 commented May 21, 2021

pavolloffay left a comment

Choose a reason for hiding this comment

pavolloffay Jun 3, 2021

Choose a reason for hiding this comment

jpkrohling Jun 3, 2021

Choose a reason for hiding this comment

rubenvp8510 commented Jun 3, 2021

rubenvp8510 commented May 19, 2021 •

edited

Loading

codecov bot commented May 19, 2021 •

edited

Loading