Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to indicate PriorityClass for collector and query #1413

Merged
merged 2 commits into from
Mar 18, 2021
Merged

Add ability to indicate PriorityClass for collector and query #1413

merged 2 commits into from
Mar 18, 2021

Conversation

majidazimi
Copy link
Contributor

Note:

it seems make generate introduced some unwanted changes in deploy/jaegertracing.io_jaegers_crd.yaml. Not sure whether these changes are required.

@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #1413 (55aa8e2) into master (d8fbe6c) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 55aa8e2 differs from pull request most recent head 71c9461. Consider uploading reports for the commit 71c9461 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1413      +/-   ##
==========================================
+ Coverage   86.71%   86.73%   +0.02%     
==========================================
  Files          90       90              
  Lines        5021     5029       +8     
==========================================
+ Hits         4354     4362       +8     
  Misses        513      513              
  Partials      154      154              
Impacted Files Coverage Δ
pkg/apis/jaegertracing/v1/jaeger_types.go 100.00% <ø> (ø)
pkg/deployment/collector.go 100.00% <100.00%> (ø)
pkg/deployment/query.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8fbe6c...71c9461. Read the comment docs.

@majidazimi majidazimi changed the title Add ability to indicate PriorityClass for collector and query WIP: Add ability to indicate PriorityClass for collector and query Mar 17, 2021
@jpkrohling
Copy link
Contributor

it seems make generate introduced some unwanted changes in deploy/jaegertracing.io_jaegers_crd.yaml. Not sure whether these changes are required.

That does look odd. Looks like we generated it with v0.3.0 of the controller-gen, but we are installing an earlier version:

sigs.k8s.io/controller-tools/cmd/[email protected] \

Could you try removing the controller-gen and installing it using the following command (if you are using Go 1.16 or higher)?

go install sigs.k8s.io/controller-tools/cmd/[email protected]

Signed-off-by: Majid Azimi <[email protected]>
Copy link
Contributor

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution!

@majidazimi majidazimi changed the title WIP: Add ability to indicate PriorityClass for collector and query Add ability to indicate PriorityClass for collector and query Mar 17, 2021
@majidazimi
Copy link
Contributor Author

So using [email protected] passes all e2e tests.

@jpkrohling jpkrohling merged commit 028965e into jaegertracing:master Mar 18, 2021
@jpkrohling
Copy link
Contributor

cc @rubenvp8510 , this needs to be added to the changelog for 1.22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants