-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to indicate PriorityClass for collector and query #1413
Conversation
Signed-off-by: Majid Azimi <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1413 +/- ##
==========================================
+ Coverage 86.71% 86.73% +0.02%
==========================================
Files 90 90
Lines 5021 5029 +8
==========================================
+ Hits 4354 4362 +8
Misses 513 513
Partials 154 154
Continue to review full report at Codecov.
|
That does look odd. Looks like we generated it with v0.3.0 of the controller-gen, but we are installing an earlier version: Line 396 in d8fbe6c
Could you try removing the controller-gen and installing it using the following command (if you are using Go 1.16 or higher)?
|
Signed-off-by: Majid Azimi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for the contribution!
So using |
cc @rubenvp8510 , this needs to be added to the changelog for 1.22 |
Note:
it seems
make generate
introduced some unwanted changes indeploy/jaegertracing.io_jaegers_crd.yaml
. Not sure whether these changes are required.