Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing release v1.22.0 #1412

Merged
merged 5 commits into from
Mar 22, 2021

Conversation

rubenvp8510
Copy link
Collaborator

Signed-off-by: Ruben Vargas [email protected]

@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #1412 (219edb2) into master (028965e) will decrease coverage by 0.00%.
The diff coverage is 85.71%.

❗ Current head 219edb2 differs from pull request most recent head 19cf498. Consider uploading reports for the commit 19cf498 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1412      +/-   ##
==========================================
- Coverage   86.73%   86.72%   -0.01%     
==========================================
  Files          90       91       +1     
  Lines        5029     5056      +27     
==========================================
+ Hits         4362     4385      +23     
- Misses        513      516       +3     
- Partials      154      155       +1     
Impacted Files Coverage Δ
pkg/upgrade/utils.go 50.00% <50.00%> (ø)
pkg/upgrade/v1_22_0.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 028965e...19cf498. Read the comment docs.

@rubenvp8510 rubenvp8510 requested a review from kevinearls March 17, 2021 08:13
@rubenvp8510 rubenvp8510 requested a review from jpkrohling March 17, 2021 13:50
@rubenvp8510 rubenvp8510 requested a review from jpkrohling March 17, 2021 14:37
@rubenvp8510 rubenvp8510 force-pushed the prepare-release-1.22.0 branch 2 times, most recently from 7b3d147 to e35a4bd Compare March 17, 2021 14:42
Copy link
Contributor

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the strconv comment, looks good to me.

jpkrohling
jpkrohling previously approved these changes Mar 18, 2021
@rubenvp8510 rubenvp8510 force-pushed the prepare-release-1.22.0 branch from 0f46efe to 19cf498 Compare March 18, 2021 14:32
@mergify mergify bot dismissed jpkrohling’s stale review March 18, 2021 14:32

Pull request has been modified.

@rubenvp8510 rubenvp8510 requested a review from jpkrohling March 18, 2021 15:24
@rubenvp8510 rubenvp8510 merged commit c319ec5 into jaegertracing:master Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants