Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set non root group #1339

Merged
merged 1 commit into from
Dec 10, 2020
Merged

set non root group #1339

merged 1 commit into from
Dec 10, 2020

Conversation

UsaninMax
Copy link
Contributor

Based on #1336 (comment)

@UsaninMax
set non root group
bb05fa9 
Signed-off-by: Max Usanin <[email protected]>
@UsaninMax UsaninMax mentioned this pull request Dec 10, 2020
Closed
@codecov
Copy link

codecov bot commented Dec 10, 2020

Codecov Report

Merging #1339 (bb05fa9) into master (e48622a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1339   +/-   ##
=======================================
  Coverage   86.02%   86.02%           
=======================================
  Files          90       90           
  Lines        5125     5125           
=======================================
  Hits         4409     4409           
  Misses        548      548           
  Partials      168      168

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e48622a...bb05fa9. Read the comment docs.

jpkrohling
jpkrohling approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mergify mergify bot merged commit 7d8cab9 into jaegertracing:master Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpkrohling jpkrohling jpkrohling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UsaninMax @jpkrohling