Set non-root user group

[UsaninMax]

Based on #1336 (comment)

[codecov]

Codecov Report

Merging #1337 (5403ce1) into master (e48622a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1337   +/-   ##
=======================================
  Coverage   86.02%   86.02%           
=======================================
  Files          90       90           
  Lines        5125     5125           
=======================================
  Hits         4409     4409           
  Misses        548      548           
  Partials      168      168           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e48622a...5403ce1. Read the comment docs.

[jpkrohling]

Could you please work on the DCO check?

[jpkrohling]

https://github.com/jaegertracing/jaeger-operator/pull/1337/checks?check_run_id=1525256256

[UsaninMax]

@jpkrohling Hi, I added Signed-off already but it's not working... what could be wrong with that ?

[jpkrohling]

There are three commits in the PR, the first one is missing the sign-off:

You might want to squash all commits, and sign-off the resulting: git rebase -i master (select pick for the first, squash for the other two), then git commit --amend --signoff to make sure the single commit is signed-off. Finally, force-push it.

[UsaninMax]

There are three commits in the PR, the first one is missing the sign-off:

You might want to squash all commits, and sign-off the resulting: git rebase -i master (select pick for the first, squash for the other two), then git commit --amend --signoff to make sure the single commit is signed-off. Finally, force-push it.

if they were already pushed to the master? and now I do not see any options to pick and squash...

[jpkrohling]

if they were already pushed to the master?

You can try upstream/master then instead (provided that upstream is this repository here as remote). But it's a good reason to use a feature branch: git checkout -b pr1337 ;-)

[UsaninMax]

@jpkrohling I created new one, and DCO is ok

#1339

[jpkrohling]

Closing in favor of #1339