add serviceType for the collector service

[sschne]

Adds serviceType option for the collector service.

Closes: #1263

Signed-off-by: Simon Schneider [email protected]

[codecov]

Codecov Report

Merging #1286 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1286   +/-   ##
=======================================
  Coverage   87.32%   87.33%           
=======================================
  Files          89       89           
  Lines        4947     4957   +10     
=======================================
+ Hits         4320     4329    +9     
- Misses        464      465    +1     
  Partials      163      163           

Impacted Files	Coverage Δ
pkg/apis/jaegertracing/v1/jaeger_types.go	100.00% <ø> (ø)
pkg/service/collector.go	100.00% <100.00%> (ø)
pkg/controller/jaeger/jaeger_controller.go	36.87% <0.00%> (+1.23%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c418931...0867f39. Read the comment docs.

[jpkrohling]

Looks good! Could we have an example under /examples, showing how to use it? People ask about this quite often. It would also be good to have this new example as part of the e2e tests, so that we can document whether this works in non-vanilla Kubernetes (OpenShift, for instance).

[jpkrohling]

LGTM. @kevinearls, would you please check whether the example test looks sane to you?

[jpkrohling]

By the way: I just confirmed that the new test is being executed and is passing:

2020-11-05T21:29:55.6721753Z     --- PASS: TestExamplesSuite2/TestServiceTypesExample (51.45s)

[kevinearls]

The test changes LGTM.

[sschne]

Is there anything missing for this PR?

[jpkrohling]

No, I was expecting mergify to merge it, but for some reason, it didn't (codecov checks missing?). I merged this manually.