Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow service types to be configured #1263

Closed
kevinjqiu opened this issue Oct 15, 2020 · 3 comments · Fixed by #1286
Closed

Allow service types to be configured #1263

kevinjqiu opened this issue Oct 15, 2020 · 3 comments · Fixed by #1286
Labels
enhancement New feature or request

Comments

@kevinjqiu
Copy link

Currently, all services are created as ClusterIP type services. This is adequate if everything is run inside the kubernetes cluster. For our use case, we need to deploy the collector on a kube cluster but we have a variety of ways to deploy agents, e.g., directly on a VM outside of the cluster.

This means we need to expose the agent GRPC service so it can be reached by the agents outside of the cluster. Since it's the GRPC service, we can't use ingress. It'd be nice if we can configure the service for each individual component which allows us to specify serviceType: NodePort or even LoadBalancer.

Thanks,

@github-actions github-actions bot added the needs-triage New issues, in need of classification label Oct 15, 2020
@jpkrohling jpkrohling added enhancement New feature or request and removed needs-triage New issues, in need of classification labels Oct 15, 2020
@jpkrohling
Copy link
Contributor

jpkrohling commented Oct 19, 2020

We've had a PR adding this to the query service (#1132). Exposing the collector to outside of the cluster should never be the default option, but I think it might be reasonable to align the collector's service with the query.

@jpkrohling
Copy link
Contributor

This might be related as well: #1048

@kevinjqiu
Copy link
Author

This might be related as well: #1048

For HTTP thrift services, sure, but the GRPC service cannot be exposed by way of ingress, since ingresses are HTTP only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants