Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specific values for nodeport to be configured #1307

Closed
csp197 opened this issue Nov 18, 2020 · 3 comments · Fixed by #1394
Closed

Allow specific values for nodeport to be configured #1307

csp197 opened this issue Nov 18, 2020 · 3 comments · Fixed by #1394
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@csp197
Copy link
Contributor

csp197 commented Nov 18, 2020

As a user of jaeger-operator, I would like to expose the jaeger-query service in my K8s VPC.

As per #1263, I understand that a service type can be set via -

query:
      serviceType: NodePort

But it would be nice if a user could specify a constant value for the exposed nodeport as follows -

query:
      serviceType: NodePort
      nodePort: 3####

Thanks all,
@github-actions github-actions bot added the needs-triage New issues, in need of classification label Nov 18, 2020
@jpkrohling jpkrohling added enhancement New feature or request good first issue Good for newcomers and removed needs-triage New issues, in need of classification labels Nov 23, 2020
@dogukanturan
Copy link

I guess we can't add NodePort and we can't make a static ClusterIP definition either.

csp197 added a commit to csp197/jaeger-operator that referenced this issue Feb 15, 2021
@csp197
jaegertracing#1307: Adding support for NodePort in Jaeger Query Service
05fc75a
csp197 added a commit to csp197/jaeger-operator that referenced this issue Feb 16, 2021
@csp197
jaegertracing#1307: Adding support for NodePort in Jaeger Query Service
9dc318e 
Signed-off-by: GitHub <[email protected]>
csp197 added a commit to csp197/jaeger-operator that referenced this issue Feb 16, 2021
@csp197
jaegertracing#1307: Adding support for NodePort in Jaeger Query Service
5963567 
Signed-off-by: GitHub <[email protected]>
@csp197 csp197 mentioned this issue Feb 17, 2021
Merged
@csp197
Copy link
Contributor Author

csp197 commented Feb 17, 2021

@jpkrohling - Can you pls review my PR: #1394?

@jpkrohling
Copy link
Contributor

@rubenvp8510 will take a look at this one

@mergify mergify bot closed this as completed in #1394 Mar 27, 2021
mergify bot pushed a commit that referenced this issue Mar 27, 2021
@csp197
Add support for NodePort in Jaeger Query Service (#1394)
52b4c70 
This PR should allow users to expose Jaeger's Query service as a NodePort at a specific port. Earlier, the Jaeger Operator did not support specifying a port value and would depend on K8s to randomly select an apt port value. This should resolve this blocker.

Resolves #1307
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for NodePort in Jaeger Query Service csp197/jaeger-operator
3 participants
@jpkrohling @csp197 @dogukanturan