Add support for imagePullSecrets to sidecar's Deployment #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 3, 2020 17:23
Signed-off-by: Saad Hussain <[email protected]>
Signed-off-by: Saad Hussain <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1115 +/- ##
==========================================
+ Coverage 88.05% 88.07% +0.02%
==========================================
Files 86 86
Lines 5274 5284 +10
==========================================
+ Hits 4644 4654 +10
Misses 466 466
Partials 164 164
Continue to review full report at Codecov.
|
jpkrohling
approved these changes
Jul 6, 2020
… when adding a new one for the sidecar agent Signed-off-by: Saad Hussain <[email protected]>
|
Thank you for another contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original git issue: #1018
Previous (erroneous) PR for context: #1103
imagePullSecrets can be configured for components by providing a custom serviceAccount for the component and specifying the imagePullSecrets in the serviceAccount. However, the agent sidecar does not support custom serviceAccounts since its Deployment may already use a serviceAccount. This PR adds support for
imagePullSecretsto the agent spec for cases where an imagePullSecret for the sidecar is desired.PR to update documentation: jaegertracing/documentation#416