Add image pull secrets to Jaeger resources #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n" section based on associated jaeger-operator PR Signed-off-by: Saad Hussain <[email protected]>
added 3 commits
July 3, 2020 10:51
…rs (e.g. imagePullSecrets) Signed-off-by: Saad Hussain <[email protected]>
Signed-off-by: Saad Hussain <[email protected]>
Signed-off-by: Saad Hussain <[email protected]>
jpkrohling
approved these changes
Jul 6, 2020
There was a problem hiding this comment.
LGTM, but it could be good to have @objectiser to give a final look
| @@ -972,6 +1000,8 @@ spec: | |||
| path: log_level | |||
| ``` | |||
|
|
|||
| Note: If necessary, imagePullSecrets can be configured for components through their serviceAccounts (see https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/#add-image-pull-secret-to-service-account). For the sidecar, see the [Deployment-level Configurations for Injected Sidecars](#deployment-level-configurations-for-injected-sidecars) section. | |||
|
This is to be merged once jaegertracing/jaeger-operator#1115 is merged. |
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated PR: jaegertracing/jaeger-operator#1103Associated PR: jaegertracing/jaeger-operator#1115
This PR updates the documentation to mention the capability to specify imagePullSecrets for Jaeger resources.