This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
Support Tracer tags and configuration via environment variables #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing#178) Signed-off-by: FR-MUREX-COM\mchaikhadouaihy <[email protected]>
|
✅ Build jaeger-client-cpp 43 completed (commit d3ba66688d by @mdouaihy) |
yurishkuro
changed the title
2 tasks
|
Hi @yurishkuro, any comment on this PR? |
yurishkuro
reviewed
Oct 8, 2019
1. When testing the config, start with a defined config instead of an empty one 2. Make sure fromEnv is harmful in case nothing is defined 3. Use literals to avoid fat-finger problem in the code 4. Avoid adding yet additional methods to the Tracer Signed-off-by: FR-MUREX-COM\mchaikhadouaihy <[email protected]>
|
✅ Build jaeger-client-cpp 44 completed (commit 7bb24f99d0 by @mdouaihy) |
Signed-off-by: FR-MUREX-COM\mchaikhadouaihy <[email protected]>
|
✅ Build jaeger-client-cpp 45 completed (commit 10d803716d by @mdouaihy) |
|
thank you @yurishkuro ! |
Patrick0308
pushed a commit
to Patrick0308/jaeger-client-cpp
that referenced
this pull request
Jul 21, 2021
…ertracing#181) * Support configuring client from environment variables (fix jaegertracing#178) Signed-off-by: FR-MUREX-COM\mchaikhadouaihy <[email protected]> * Apply Changes requested by @Yurishkhuro 1. When testing the config, start with a defined config instead of an empty one 2. Make sure fromEnv is harmful in case nothing is defined 3. Use literals to avoid fat-finger problem in the code 4. Avoid adding yet additional methods to the Tracer Signed-off-by: FR-MUREX-COM\mchaikhadouaihy <[email protected]> * Exclude sampler config. Signed-off-by: FR-MUREX-COM\mchaikhadouaihy <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: FR-MUREX-COM\mchaikhadouaihy [email protected]
Which problem is this PR solving?
Short description of the changes
Supported properties