Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

Support configuring client from environment variables #178

Closed
1 of 2 tasks
yurishkuro opened this issue Sep 29, 2019 · 3 comments · Fixed by #181
Closed
1 of 2 tasks

Support configuring client from environment variables #178

yurishkuro opened this issue Sep 29, 2019 · 3 comments · Fixed by #181
Labels
help wanted

Comments

@yurishkuro
Copy link
Member

yurishkuro commented Sep 29, 2019 •
edited
Loading

Most Jaeger clients support that, cf. https://www.jaegertracing.io/docs/client-features/
@yurishkuro yurishkuro mentioned this issue Sep 29, 2019
Merged
@yurishkuro
Copy link
Member Author

Note: it is better to support FromEnv() function on an existing Config object, so that, for example, a default config could be programmatically populated by the application, but could be also overwritten with environment variables. Cf. jaegertracing/jaeger-client-go#436

mdouaihy added a commit to mdouaihy/jaeger-client-cpp that referenced this issue Oct 5, 2019
@mdouaihy
Support configuring client from environment variables (fix jaegertrac…
ff65da4 
…ing#178)

Signed-off-by: FR-MUREX-COM\mchaikhadouaihy <[email protected]>
mdouaihy added a commit to mdouaihy/jaeger-client-cpp that referenced this issue Oct 5, 2019
@mdouaihy
Support configuring client from environment variables (fix jaegertrac…
d343fde 
…ing#178)

Signed-off-by: FR-MUREX-COM\mchaikhadouaihy <[email protected]>
@mdouaihy mdouaihy mentioned this issue Oct 6, 2019
Merged
yurishkuro pushed a commit that referenced this issue Oct 8, 2019
@mdouaihy @yurishkuro
Support Tracer tags and configuration via environment variables (#181)
5fc9c65 
* Support configuring client from environment variables (fix #178)

Signed-off-by: FR-MUREX-COM\mchaikhadouaihy <[email protected]>

* Apply Changes requested by @Yurishkhuro
1. When testing the config, start with a defined config instead of an empty one
2. Make sure fromEnv is harmful in case nothing is defined
3. Use literals to avoid fat-finger problem in the code
4. Avoid adding yet additional methods to the Tracer

Signed-off-by: FR-MUREX-COM\mchaikhadouaihy <[email protected]>

* Exclude sampler config.

Signed-off-by: FR-MUREX-COM\mchaikhadouaihy <[email protected]>
@yurishkuro
Copy link
Member Author

Re-opening since we also need documentation change

@yurishkuro yurishkuro reopened this Oct 8, 2019
@yurishkuro
Copy link
Member Author

@bhavin192 fyi in case you want to pick it up

@eundoosong eundoosong mentioned this issue Jan 20, 2020
Merged
Patrick0308 pushed a commit to Patrick0308/jaeger-client-cpp that referenced this issue Jul 21, 2021
@mdouaihy @Patrick0308
Support Tracer tags and configuration via environment variables (jaeg…
07511d1 
…ertracing#181)

* Support configuring client from environment variables (fix jaegertracing#178)

Signed-off-by: FR-MUREX-COM\mchaikhadouaihy <[email protected]>

* Apply Changes requested by @Yurishkhuro
1. When testing the config, start with a defined config instead of an empty one
2. Make sure fromEnv is harmful in case nothing is defined
3. Use literals to avoid fat-finger problem in the code
4. Avoid adding yet additional methods to the Tracer

Signed-off-by: FR-MUREX-COM\mchaikhadouaihy <[email protected]>

* Exclude sampler config.

Signed-off-by: FR-MUREX-COM\mchaikhadouaihy <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support Tracer tags and configuration via environment variables mdouaihy/jaeger-client-cpp
1 participant
@yurishkuro