feat(windows) powershell and batch support (fix mac) #58
Conversation
Co-Authored-By: Jake Deichert <[email protected]>
|
Previous discussion over here: #45 @tensor-programming thank you for reopening this PR 👍 I'll find time to figure out the macOS issue this weekend hopefully. Surprised CI/linux has no issues but mac does 😂 |
|
What actually going on on Mac? Ill get one of my guys to look at it. |
|
After building this branch and running that version of mask locally with the root maskfile, this error occurs: When I removed the powershell code blocks, I believe it fixed the issue. So it might be something to do with mac trying to run the powershell block or something. I didn't get to it this weekend unfortunately. Might tackle in the next few nights. |
|
What I can do is update the CI for mac and see if I can get it to build with my fixes. |
…tensor-programming/mask into feat/windows-powershell-support
|
Interesting, it seems that at least on the Github virtual machine there are no errors (running the tests). I will have to get one of my guys to check it out since I don't have a mac myself. Edit: few of the macs devs on Tauri all ran it and didn't see an issue. It seems that whatever the problem is, is inconsistent from machine to machine. Perhaps the machine in question has powershell installed or something like that? |
There was a problem hiding this comment.
Okay, so i figured out what was going on.
When I ran this branch locally before, I was running mask link and getting this error:
ERROR: No such file or directory (os error 2)
The problem is that mask version 0.7.1 cannot read this updated maskfile with powershell blocks. It's trying to run the powershell since those blocks are the last code block in each section.
I had thought that this branch was broken but it was the fact that I wasn't using this version of mask to run the test suite. Completely my bad here... haven't been into this project for awhile and didn't realize what was going on (though i do use mask dozens of times a day 😅). I fixed this locally by running cargo install --force --path . manually instead of mask link and everything works great.
I'm working on a release for this today! Thanks again for all the work you've put into this... including getting CI support setup for windows AND mac! 🎉
Apologies for the delay too. I've been caught up with other projects recently (svelvet) and a little burnt out from working on stuff. Mask is my most important OSS project though, so it should get the most focus going forwards 👍
| - name: Checkout master | ||
| uses: actions/checkout@master | ||
| - name: Verify formatting is correct | ||
| run: cargo fmt --all -- --check |
There was a problem hiding this comment.
I think you accidentally removed formatting from CI? I'll fix on master so i can get this merged.
There was a problem hiding this comment.
I guess I did. Woops, sorry about that.
|
Nice to see that this got merged without issue. Glad it wasn't some esoteric problem and just a little user error (happens to the best of us). cheers mate. |
Which issue does this fix?
Closes #10
Describe the solution
Adds Batch and powershell support to Mask.