Windows support?

[jacobdeichert]

Currently, this is unknown. I'm pretty sure the executor logic will need to be adjusted for Windows.

[Coteh]

FWIW, I tried removing all paths to sh.exe from my system (i.e. removing paths such as C:\Program Files\Git\cmd which contains the Git for Windows version of sh, as well as renaming other instances of sh.exe on my system that were being picked up like the ones included with Cmder), ensured that sh was no longer being referenced by running where sh, then tried running mask. I found that the program seems to exit without doing anything nor does it print any sort of error to the terminal.

[jacobdeichert]

Thanks for checking this! So it sounds like mask works with the git bash shell and probably also Ubuntu on Windows.

[jacobdeichert]

Oh i misread this clearly. Sounds like mask does not work on windows.

[shanoaice]

@jakedeichert I suppose if we add PowerShell as a scripting runtime, this could be solved.

[jacobdeichert]

Adding PowerShell support will probably be useful to people 👍

But mask should also work with WSL and bash/sh scripting. I have a feeling it's also not handling Windows paths correctly...

[tensor-programming]

We're adding mask to our project Tauri, and the powershell support works out of the box it seems. If I add a block to the maskfile.md in the mask repo, that just looks like this:

~~~powershell
Write-Output "Test Output"
cargo build --release
~~~

it runs without an issue.

I've already worked out some stuff for windows support and will create a PR.

[jacobdeichert]

@tensor-programming wow, really? That must mean that powershell supports a -c arg?

I googled this and can't find anything about powershell -c. That's really good to know if it works.

Does WSL/bash on windows work too?

I maybe can close this issue if both work :)

[tensor-programming]

The -c in powershell is short for -Command.

WSL does work out of the box without any changes. With the PR I made for powershell, I did have to do a little tweaking with the parser to have it ignore powershell and Batch blocks on Linux/WSL. On windows, it ignores shell blocks automatically for some reason which is a nice side effect.

[tensor-programming]

Submitted my PR. If you want, I can add a github action to test and build mask on Windows.

[jacobdeichert]

I had to revert the windows PR that was merged.

Reopening until I fix the issue with mask on macOS

[tensor-programming]

Ahh, something I couldn't test. Ill have to get one of my devs to take a look from a mac perspective.

[jacobdeichert]

@tensor-programming no worries at all! I usually test PRs locally but forgot to in this case :)

I'll work on the macOS issue this weekend hopefully 🤞

[jacobdeichert]

Released as v0.8.0! https://github.com/jakedeichert/mask/releases/tag/v0.8.0