-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(task-runner): add self-documented task runner #486
Conversation
`mask` can also act as self-documented task runner https://github.com/jakedeichert/mask TODO: add demo.gif on opening this PR
with assumption it only happen on examples/rust
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome.
Wow this is so cool. Btw do we have a contribution guide? |
@DrSensor very cool! I have been working on a good workflow using yarn workspaces for the examples, but that won't cover the rust based examples. This looks like it has the capability though which is great. It appears that this may not work on Windows though which is unfortunate 😣. My other thought is that I wonder if this is best added to the examples repo? |
@jbolda That's possible and it will be composable by referencing
I'm not a Windows user but this task-runner might work on Windows via WSL. The thing that I'm not sure is if WSL handle the path in the same way as Linux 🤔 (cc: @tensor-programming ) |
I was actually thinking only have the maskfile in https://github.com/tauri-apps/examples as the functions relate specifically to them. I guess my personal opinion regarding the examples is that they serve strictly as test grounds and the expectation is that they won't be cloned to start a project. Instead we push towards using the CLI to start a project. What do others think? It seems to always be an ongoing discussion. The paths certainly could be an issue on Windows, but if it works in bash and WSL that's better than nothing. |
@jbolda - can't we do both? |
@nothingismagick If that is what you would like to do, it's not unreasonable. We would have to maintain it in both places, but there are worse situations. |
Ill look into making it work on windows but bash and wsl only support is a bit unacceptable. Most windows devs don't use either or would rather not use either. Mask looks like it works out of the box for Powershell. Just put some powershell in a block and it works without any changes to the codebase. I added a block to the project's main build block:
|
@tensor-programming - with your powershell amendment this could be approved? |
its being looked at here: jacobdeichert/mask#45 They said they would review it next week. |
can this be merged already? |
We were waiting on the upstream next version with @tensor-programming changes. |
This can likely be merged, the changes where made a few weeks ago. Will have to add some windows ps1/batch related commands but yes, its all good to go. (edit) Looks like the PR was actually removed later. You guys can still merge this, the windows support will just have to come after they sort out a mac related issue and remerge the windows PR. |
Thanks @DrSensor for taking care of this! |
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch and not themaster
branchfix: #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
As a new/first contributor, I have difficulty to check the small changes that I made is correct, especially when I want to check if it works on the examples repo. I'm choosing mask because it's markdown which can be used as some sort of recipe. (also I'm more familiar with
mask
codebase)