Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to point to a different maskfile #19

Merged
merged 7 commits into from
Jul 21, 2019
Merged

Make it possible to point to a different maskfile #19

merged 7 commits into from
Jul 21, 2019

Conversation

felipesere
Copy link
Contributor

This PR adds the ability to specify --maskfile or -m followed by a path to a maskfile.

I had to work around the fact that clap will still parse all of the arguments from argv, so I had to add a subcommand to match --maskfile (see the comment below).

Other than that I added a the dev-dependencies to start writing integration tests for the binary.

Let me know what you think!

@felipesere felipesere mentioned this pull request Jul 20, 2019
@felipesere
Copy link
Contributor Author

Solves #7

@jacobdeichert
Copy link
Owner

Hey Felipe, thanks for doing this!

I've got a busy weekend ahead, but i'll try to give this another look tonight or late tomorrow. Looks good at first glance 👍

Copy link
Owner

@jacobdeichert jacobdeichert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for doing this! It works great 💯.

This actually unleashes a new use case: global commands that people can use a bash alias to execute for simplicity. I'll document this after the merge.

Can you accept/commit the suggestions and then I'll merge?

src/main.rs Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
src/main.rs Show resolved Hide resolved
tests/integration_test.rs Outdated Show resolved Hide resolved
tests/integration_test.rs Show resolved Hide resolved
felipesere and others added 5 commits July 21, 2019 22:23
Co-Authored-By: Jake Deichert <[email protected]>
Co-Authored-By: Jake Deichert <[email protected]>
Co-Authored-By: Jake Deichert <[email protected]>
Co-Authored-By: Jake Deichert <[email protected]>
src/main.rs Outdated Show resolved Hide resolved
Co-Authored-By: Jake Deichert <[email protected]>
@felipesere
Copy link
Contributor Author

All changes should be up to date now.

@jacobdeichert
Copy link
Owner

Thanks for being so quick! 😄

@jacobdeichert jacobdeichert merged commit 9826416 into jacobdeichert:master Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants