-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to point to a different maskfile #19
Conversation
Solves #7 |
Hey Felipe, thanks for doing this! I've got a busy weekend ahead, but i'll try to give this another look tonight or late tomorrow. Looks good at first glance 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for doing this! It works great 💯.
This actually unleashes a new use case: global commands that people can use a bash alias to execute for simplicity. I'll document this after the merge.
Can you accept/commit the suggestions and then I'll merge?
Co-Authored-By: Jake Deichert <[email protected]>
Co-Authored-By: Jake Deichert <[email protected]>
Co-Authored-By: Jake Deichert <[email protected]>
Co-Authored-By: Jake Deichert <[email protected]>
Co-Authored-By: Jake Deichert <[email protected]>
Co-Authored-By: Jake Deichert <[email protected]>
All changes should be up to date now. |
Thanks for being so quick! 😄 |
This PR adds the ability to specify
--maskfile
or-m
followed by a path to a maskfile.I had to work around the fact that clap will still parse all of the arguments from
argv
, so I had to add a subcommand to match--maskfile
(see the comment below).Other than that I added a the dev-dependencies to start writing integration tests for the binary.
Let me know what you think!