Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying an external maskfile.md to use #7

Closed
jacobdeichert opened this issue Jul 13, 2019 · 2 comments
Closed

Allow specifying an external maskfile.md to use #7

jacobdeichert opened this issue Jul 13, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@jacobdeichert
Copy link
Owner

jacobdeichert commented Jul 13, 2019

Right now mask looks for a maskfile or maskfile.md in the current directory.

We should add a --maskfile <path> option so that mask can refer to another maskfile.md at the given path.

Perhaps it should also look for maskfiles in parent directories until it finds one?

Example use case:
Sometimes i'm working in a subdir of a monorepo project. Being able to put a maskfile at root of the monorepo would be nice if I could call mask from any location in that tree.

@jacobdeichert jacobdeichert added the enhancement New feature or request label Jul 13, 2019
@jacobdeichert jacobdeichert changed the title Maybe look for maskfiles in parent directories? Allow specifying an external maskfile.md to use Jul 16, 2019
@jacobdeichert
Copy link
Owner Author

Fixed by #19 🎉

@jacobdeichert
Copy link
Owner Author

Perhaps it should also look for maskfiles in parent directories until it finds one?

This still might be useful as a default behavior. I'll need to think about this further.

There's a good alternative for user land right now: make a bash alias to mask that searches up the directory tree for a maskfile.md and then execute mask --maskfile $(pwd)/maskfile.md on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant