Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submodules #96

Open
TroyKomodo opened this issue Feb 20, 2023 · 2 comments
Open

Submodules #96

TroyKomodo opened this issue Feb 20, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@TroyKomodo
Copy link

Mask is very cool!

The one feature I think would make it much cleaner is the ability for submodules.

Right now we have

## build
...
## test
...

where we have all the commands in a single long file.

Ideally you should allow

## [build](./mask/build.md)
## [test](./mask/test.md)

Even looks cool on MD.
TroyKomodo added a commit to ScuffleCloud/scuffle that referenced this issue Feb 20, 2023
@TroyKomodo
chore: switch to mask, fix some git ignores
8825290 
Switched to mask as our task runner from Just.
Mask seems to provide a much nicer cli than just and also is much easier
to write than the just files, since its markdown. Ideally they should
add support for submoudles and some things to help with code
duplication. Like global variables, global scripts, cascading flags,
catch all extra arguments, ect... However these are not big enough
issues for us to not use it since just/make is very unmaintainable and very
messy when we have a lot of tasks.

I made an issue on their repo for the submodule idea.
jacobdeichert/mask#96
TroyKomodo added a commit to ScuffleCloud/scuffle that referenced this issue Feb 20, 2023
@TroyKomodo
chore: switch to mask + small other fixes
606624d 
Switched to mask as our task runner from Just.
Mask seems to provide a much nicer cli than just and also is much easier
to write than the just files, since its markdown. Ideally they should
add support for submoudles and some things to help with code
duplication. Like global variables, global scripts, cascading flags,
catch all extra arguments, ect... However these are not big enough
issues for us to not use it since just/make is very unmaintainable and very
messy when we have a lot of tasks.

I made an issue on their repo for the submodule idea.
jacobdeichert/mask#96

Some small fixes:
- .gitignores on mac
- prettier not formatting all files
@jacobdeichert
Copy link
Owner

Hey, thanks for checking out mask!

If I understand correctly, this would act like a shortcut for accessing commands in some other maskfile. So if I ran mask build <some_cmd> that some_cmd would be defined as an h2 (## some_cmd) inside the ./mask/build.md file, right? So mask would have to resolve and merge all sub-maskfiles into the main maskfile structure and then determine which command the user wants to run.

This does sound like it could be an improvement for teams with very large maskfile structures, but I haven't heard of or seen any maskfiles large enough to need this yet.

I'll leave this issue open as an idea for improvement. For now, let's wait and see if more users/teams request it.

@jacobdeichert jacobdeichert added the enhancement New feature or request label Feb 21, 2023
@TroyKomodo
Copy link
Author

More so like having subcommands in a separate file. Like if I have a lot of commends related to build they could be in a build.maskfile

TroyKomodo pushed a commit to ScuffleCloud/scuffle that referenced this issue Feb 24, 2023
@mmattbtw @TroyKomodo
feat: start landing page
d9f1323 
Closes #35

fix: switch to scss

feat: finish up layout

chore: switch to mask + small other fixes

Switched to mask as our task runner from Just.
Mask seems to provide a much nicer cli than just and also is much easier
to write than the just files, since its markdown. Ideally they should
add support for submoudles and some things to help with code
duplication. Like global variables, global scripts, cascading flags,
catch all extra arguments, ect... However these are not big enough
issues for us to not use it since just/make is very unmaintainable and very
messy when we have a lot of tasks.

I made an issue on their repo for the submodule idea.
jacobdeichert/mask#96

Some small fixes:
- .gitignores on mac
- prettier not formatting all files

feat: start landing page

Closes #35

fix: switch to scss

fix: remove unused file

feat: fix magic text positioning

chore: format

fix: capitalization

chore: add code coverage

Add code coverage with Codecov.

closes #50

feat: add blurred circles to background

chore: format

fix: remove unused <script>

fix: text selection on top of blurred circles

feat: added blurred-circle animation

feat(api): initial api implementation + glibc

Upon testing the API we noticed that when the app is compiled with musl
the API would perform roughly 80% worse than the glibc counter part.
We will have to do real benchmarks to see where this performance drop
off is coming from and likely have to ticket it to the musl / rust /
tokio devs.

ci: add docker ci builds

Adding docker builds to CI so that we can have regularly updated docker
images pushed to GHCR.

closes #46
TroyKomodo pushed a commit to ScuffleCloud/scuffle that referenced this issue Feb 24, 2023
@mmattbtw @TroyKomodo
feat: start landing page
51197c6 
Closes #35

fix: switch to scss

feat: finish up layout

chore: switch to mask + small other fixes

Switched to mask as our task runner from Just.
Mask seems to provide a much nicer cli than just and also is much easier
to write than the just files, since its markdown. Ideally they should
add support for submoudles and some things to help with code
duplication. Like global variables, global scripts, cascading flags,
catch all extra arguments, ect... However these are not big enough
issues for us to not use it since just/make is very unmaintainable and very
messy when we have a lot of tasks.

I made an issue on their repo for the submodule idea.
jacobdeichert/mask#96

Some small fixes:
- .gitignores on mac
- prettier not formatting all files

feat: start landing page

Closes #35

fix: switch to scss

fix: remove unused file

feat: fix magic text positioning

chore: format

fix: capitalization

chore: add code coverage

Add code coverage with Codecov.

closes #50

feat: add blurred circles to background

chore: format

fix: remove unused <script>

fix: text selection on top of blurred circles

feat: added blurred-circle animation

feat(api): initial api implementation + glibc

Upon testing the API we noticed that when the app is compiled with musl
the API would perform roughly 80% worse than the glibc counter part.
We will have to do real benchmarks to see where this performance drop
off is coming from and likely have to ticket it to the musl / rust /
tokio devs.

ci: add docker ci builds

Adding docker builds to CI so that we can have regularly updated docker
images pushed to GHCR.

closes #46
TroyKomodo pushed a commit to mmattbtw/scuffle that referenced this issue Feb 24, 2023
@mmattbtw @TroyKomodo
feat: start landing page
75ce676 
Closes ScuffleCloud#35

fix: switch to scss

feat: finish up layout

chore: switch to mask + small other fixes

Switched to mask as our task runner from Just.
Mask seems to provide a much nicer cli than just and also is much easier
to write than the just files, since its markdown. Ideally they should
add support for submoudles and some things to help with code
duplication. Like global variables, global scripts, cascading flags,
catch all extra arguments, ect... However these are not big enough
issues for us to not use it since just/make is very unmaintainable and very
messy when we have a lot of tasks.

I made an issue on their repo for the submodule idea.
jacobdeichert/mask#96

Some small fixes:
- .gitignores on mac
- prettier not formatting all files

feat: start landing page

Closes ScuffleCloud#35

fix: switch to scss

fix: remove unused file

feat: fix magic text positioning

chore: format

fix: capitalization

chore: add code coverage

Add code coverage with Codecov.

closes ScuffleCloud#50

feat: add blurred circles to background

chore: format

fix: remove unused <script>

fix: text selection on top of blurred circles

feat: added blurred-circle animation

feat(api): initial api implementation + glibc

Upon testing the API we noticed that when the app is compiled with musl
the API would perform roughly 80% worse than the glibc counter part.
We will have to do real benchmarks to see where this performance drop
off is coming from and likely have to ticket it to the musl / rust /
tokio devs.

ci: add docker ci builds

Adding docker builds to CI so that we can have regularly updated docker
images pushed to GHCR.

closes ScuffleCloud#46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jacobdeichert @TroyKomodo